0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-04 10:39:43 +08:00
discourse/spec/services/upcoming_changes
Isaac Janzen 1599c4512b
FIX: Restrict upcoming-changes toggle to registered upcoming-change settings (#42175)
## Summary

The admin upcoming-changes toggle endpoint accepted any public
zero-argument SiteSetting method as a valid setting name. The fix
restricts eligibility to registered upcoming-change metadata by checking
UpcomingChanges.exists? instead of SiteSetting.respond_to?, preventing
invocation of non-setting methods like notify_changed!.

## Source

- Patch Triage: https://patch.discourse.org/patch-triage/1508

Co-authored-by: discourse-patch-triage
<272280883+discourse-patch-triage[bot]@users.noreply.github.com>
2026-07-30 09:28:04 -05:00
..
action DEV: Prefer RSpec primitives for test setup (#42122) 2026-07-30 11:17:22 +08:00
list_spec.rb DEV: Show depends_on site settings for upcoming changes (#41646) 2026-07-14 09:29:47 +10:00
notify_promotion_spec.rb FIX: Do not notify new sites or plugins enabled of old upcoming changes (#42045) 2026-07-30 09:51:08 +10:00
notify_promotions_spec.rb FIX: Do not notify new sites or plugins enabled of old upcoming changes (#42045) 2026-07-30 09:51:08 +10:00
toggle_spec.rb FIX: Restrict upcoming-changes toggle to registered upcoming-change settings (#42175) 2026-07-30 09:28:04 -05:00
track_spec.rb FEATURE: Change upcoming change available notification cadence (#40157) 2026-05-25 09:38:33 +10:00