mirror of
https://github.com/discourse/discourse.git
synced 2026-08-07 13:19:19 +08:00
7b2a2d5fde**Disclaimer: Claude was the driver here mostly, but I tested before/after locally** Attempts to fix some issues with the Zoom livestream integration when a user clicks Join before the webinar has started by the host. This shows a 30s countdown timer and then attempts to join the webinar when the countdown ends. However, when the tab wasn't focused/visible, Chrome (and assuming other browsers) do some throttling of timers, requestAnimationFrame, and ResizeObserver callbacks. When the user switches back to the tab, the Zoom video frame appeared to not be rendered. The Zoom frame was `display: none` when `init()` measured it, the desktop rule setting that had a higher specificity than the `--visible` class meant to reveal it, so the class never applied and the element only became visible once Zoom wrote an inline `display` of its own. `computeZoomViewSize` read a zero width and clamped to its 240px minimum, meaning every session configured Zoom at the wrong size. That went unnoticed because the post-join sync corrected it immediately. But that sync runs in a frame callback, and both it and the modifier's resize observer are suspended while the document is hidden. A retry that landed in a background tab never got the correction, and the single queued frame callback fired on return racing Zoom's remount, so the meeting rendered at 240px with none of the layout heights applied, making it seem like the video didn't appear. Moves the base `display: none` to where `--visible` outranks it, so the frame is laid out before Zoom is initialized; falls back to the container's width rather than the minimum when the root measures zero; and skips the frame callbacks while hidden, re-running them on `visibilitychange` instead. |
||
|---|---|---|
| .. | ||
| lib | ||
| models | ||
| ics-generation-test.js | ||
| topic-id-from-url-test.js | ||
