mirror of
https://github.com/discourse/discourse.git
synced 2026-08-11 01:57:29 +08:00
7ce1992ec1This PR makes a bookmark's "Assigned to …" badge reflect only the current, active assignment of the exact item that was bookmarked. In discourse-assign, a topic or an individual post can be assigned to a user or group, and bookmark lists show a badge for it. Previously, `BookmarkQuery.on_preload` loaded every assignment belonging to a bookmarked topic — without filtering on `active`, and keyed by `topic_id` regardless of `target_type`. Bookmarks kept showing "Assigned to …" after an assignment was deactivated (for example by `unassign_on_close`), and when a topic carried both a direct assignment and post-level assignments, whichever row loaded last won, so a bookmark could show an assignee that was never assigned the bookmarked item at all. Post bookmarks had a second problem: the `UserBookmarkBaseSerializer` extension read the topic's assignment for them, so a bookmark on an assigned post never showed that post's own assignee. |
||
|---|---|---|
| .. | ||
| flagged_topic_serializer_spec.rb | ||
| group_show_serializer_spec.rb | ||
| post_serializer_spec.rb | ||
| suggested_topic_serializer_spec.rb | ||
| topic_list_serializer_spec.rb | ||
| topic_view_serializer_spec.rb | ||
| user_bookmark_base_serializer_spec.rb | ||
