0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-09 21:45:25 +08:00
discourse/plugins/discourse-patreon/lib/api.rb
Kris 995b20ff95
FIX: clear patreon warning on successful response (#42332)
Reported here:
https://meta.discourse.org/t/dashboard-advice-regarding-patreon-persists-after-issue-is-fixed/389807/

A 401 response from the Patreon plugin permanently sets a dashboard
warning that can not be cleared. This removes the message the next time
the API has a successful response. The spec for this also couldn't fail,
so that has been corrected.
2026-08-05 09:02:10 -04:00

74 lines
2.2 KiB
Ruby
Vendored

# frozen_string_literal: true
require "json"
module Patreon
class InvalidApiResponse < ::StandardError
end
class Api
ACCESS_TOKEN_INVALID = "dashboard.patreon.access_token_invalid"
INVALID_RESPONSE = "patreon.error.invalid_response"
def self.campaign_data
adapter = ApiVersion.current
get(adapter.campaign_data_url, base_url: adapter.api_base_url)
end
def self.get(uri, base_url: ApiVersion.current.api_base_url)
limiter_hr =
RateLimiter.new(nil, "patreon_api_hr", SiteSetting.max_patreon_api_reqs_per_hr, 1.hour)
limiter_day =
RateLimiter.new(nil, "patreon_api_day", SiteSetting.max_patreon_api_reqs_per_day, 1.day)
limiter_hr.performed! unless limiter_hr.can_perform?
limiter_day.performed! unless limiter_day.can_perform?
if uri.start_with?("http")
full_url = uri
base_url = nil
else
full_url = "#{base_url}#{uri}"
end
Rails.logger.warn("Patreon API request: GET #{full_url}") if SiteSetting.patreon_verbose_log
response =
Faraday.new(
url: base_url,
headers: {
"Authorization" => "Bearer #{SiteSetting.patreon_creator_access_token}",
"User-Agent" => "Discourse Patreon Plugin/#{Discourse::VERSION::STRING}",
},
).get(full_url)
limiter_hr.performed!
limiter_day.performed!
if SiteSetting.patreon_verbose_log
Rails.logger.warn(
"Patreon API response: status=#{response.status} body_size=#{response.body&.size || 0}",
)
end
case response.status
when 200
# An inline check is never re-evaluated elsewhere, so a successful
# response is the only thing that can resolve it.
tracker = ProblemCheckTracker[:access_token_invalid]
tracker.no_problem! if tracker.failing?
return JSON.parse response.body
when 401
ProblemCheckTracker[:access_token_invalid].problem!
else
e = Patreon::InvalidApiResponse.new(response.body.presence || "")
e.set_backtrace(caller)
Discourse.warn_exception(e, message: I18n.t(INVALID_RESPONSE), env: { api_uri: uri })
end
{ error: I18n.t(INVALID_RESPONSE) }
end
end
end