mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
332e23314b## Summary Refactors the `flag_topic` branch of `PostActionsController#fetch_post_from_params` (`app/controllers/post_actions_controller.rb:68`) to replace broad exception handling with explicit topic lookup, visibility, and first-post checks. Topics that are unavailable to the current user now follow the standard not-found response path. Adds request coverage for flagging an inaccessible topic. ## Source - Patch Triage: https://patch.discourse.org/patch-triage/1325 Co-authored-by: discourse-patch-triage <272280883+discourse-patch-triage[bot]@users.noreply.github.com>
92 lines
2.3 KiB
Ruby
Vendored
92 lines
2.3 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
class PostActionsController < ApplicationController
|
|
requires_login
|
|
|
|
before_action :fetch_post_from_params
|
|
before_action :fetch_post_action_type_id_from_params
|
|
|
|
def create
|
|
raise Discourse::NotFound if @post.blank?
|
|
|
|
creator =
|
|
PostActionCreator.new(
|
|
current_user,
|
|
@post,
|
|
@post_action_type_id,
|
|
is_warning: ActiveModel::Type::Boolean.new.cast(params[:is_warning]),
|
|
message: params[:message],
|
|
take_action: params[:take_action] == "true",
|
|
flag_topic: params[:flag_topic] == "true",
|
|
queue_for_review: params[:queue_for_review] == "true",
|
|
)
|
|
result = creator.perform
|
|
|
|
if result.failed?
|
|
render_json_error(result)
|
|
else
|
|
# We need to reload or otherwise we are showing the old values on the front end
|
|
@post.reload
|
|
|
|
if @post_action_type_id == PostActionType.types[:like]
|
|
limiter = result.post_action.post_action_rate_limiter
|
|
response.headers["Discourse-Actions-Remaining"] = limiter.remaining.to_s
|
|
response.headers["Discourse-Actions-Max"] = limiter.max.to_s
|
|
end
|
|
render_post_json(@post, add_raw: false)
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
result =
|
|
PostActionDestroyer.new(
|
|
current_user,
|
|
Post.find_by(id: params[:id].to_i),
|
|
@post_action_type_id,
|
|
).perform
|
|
|
|
if result.failed?
|
|
render_json_error(result)
|
|
else
|
|
if !guardian.can_see_post?(result.post)
|
|
head :no_content
|
|
else
|
|
render_post_json(result.post, add_raw: false)
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def fetch_post_from_params
|
|
params.require(:id)
|
|
|
|
flag_topic = params[:flag_topic]
|
|
flag_topic = flag_topic && (flag_topic == true || flag_topic == "true")
|
|
|
|
post_id =
|
|
if flag_topic
|
|
topic = Topic.find_by(id: params[:id])
|
|
raise Discourse::NotFound unless guardian.can_see_topic?(topic)
|
|
|
|
post = topic.posts.first
|
|
raise Discourse::NotFound if post.blank?
|
|
|
|
post.id
|
|
else
|
|
params[:id]
|
|
end
|
|
|
|
finder = Post.where(id: post_id)
|
|
|
|
# Include deleted posts if the user is a staff
|
|
finder = finder.with_deleted if guardian.is_staff?
|
|
|
|
@post = finder.first
|
|
end
|
|
|
|
def fetch_post_action_type_id_from_params
|
|
params.require(:post_action_type_id)
|
|
@post_action_type_id = params[:post_action_type_id].to_i
|
|
end
|
|
end
|
