mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
6df9b0b357RSpec setup becomes harder to follow at either extreme: trivial fixture wrappers hide lifecycle and intent, while forcing every named operation inline repeats low-level protocol and configuration details. This change documents and applies a test-setup hierarchy: - use `fab!`, `let`, `let!`, `subject`, and inline `Fabricate` according to lifecycle and role; - use a small example-group method when parameterized behavior gives one spec useful vocabulary; - move helpers into auto-loaded `spec/support` only when they are shared across spec files; - use fabricators and page objects for the data shapes and system-test interfaces they own. Core and plugin support files are loaded centrally by `rails_helper`, so plugin-specific support loaders are unnecessary. The migration specs encountered during the sweep are removed according to repository policy; production migrations are unchanged.
43 lines
1.6 KiB
Ruby
Vendored
43 lines
1.6 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
describe SidebarSectionUpdater do
|
|
fab!(:admin)
|
|
fab!(:sidebar_section) { Fabricate(:sidebar_section, public: true) }
|
|
fab!(:first_url) { Fabricate(:sidebar_url, name: "First", value: "/first") }
|
|
fab!(:second_url) { Fabricate(:sidebar_url, name: "Second", value: "/second") }
|
|
fab!(:first_section_link) do
|
|
Fabricate(:sidebar_section_link, sidebar_section:, linkable: first_url, position: 0)
|
|
end
|
|
fab!(:second_section_link) do
|
|
Fabricate(:sidebar_section_link, sidebar_section:, linkable: second_url, position: 1)
|
|
end
|
|
|
|
it "updates the section, persists submitted link order, and publishes public updates" do
|
|
Site.expects(:clear_anon_cache!)
|
|
|
|
messages =
|
|
MessageBus.track_publish("/refresh-sidebar-sections") do
|
|
described_class.update!(
|
|
sidebar_section:,
|
|
user: admin,
|
|
section_params: {
|
|
title: "Updated section",
|
|
public: true,
|
|
},
|
|
links_params: [
|
|
{ id: second_url.id, icon: "link", name: "Second edited", value: "/second" },
|
|
{ id: first_url.id, icon: "link", name: "First edited", value: "/first" },
|
|
{ icon: "link", name: "Third", value: "/third" },
|
|
],
|
|
)
|
|
end
|
|
|
|
expect(messages.size).to eq(1)
|
|
expect(sidebar_section.reload.title).to eq("Updated section")
|
|
expect(
|
|
sidebar_section.reload.sidebar_section_links.reload.map { |link| link.linkable.name },
|
|
).to eq(["Second edited", "First edited", "Third"])
|
|
expect(UserHistory.last.action).to eq(UserHistory.actions[:update_public_sidebar_section])
|
|
expect(UserHistory.last.acting_user_id).to eq(admin.id)
|
|
end
|
|
end
|
