mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
45535887f1This reverts commit 9f4d1b5f61.
This merge unintentionally included a number of unrelated changes.
Reverting while we investigate what happened.
85 lines
3.5 KiB
Ruby
Vendored
85 lines
3.5 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe Jobs::PendingUsersReminder do
|
|
context "when must_approve_users is true" do
|
|
before do
|
|
SiteSetting.must_approve_users = true
|
|
Jobs::PendingUsersReminder.any_instance.stubs(:previous_newest_username).returns(nil)
|
|
end
|
|
|
|
it "doesn't send a message to anyone when there are no pending users" do
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
|
|
context "when there are pending users" do
|
|
before { Fabricate(:moderator, approved: true, approved_by_id: -1, approved_at: 1.week.ago) }
|
|
|
|
it "sends a message if user was created more than pending_users_reminder_delay minutes ago" do
|
|
SiteSetting.pending_users_reminder_delay_minutes = 8
|
|
user = Fabricate(:user, created_at: 9.minutes.ago)
|
|
Fabricate(:reviewable_user, target: user, created_by: Discourse.system_user)
|
|
PostCreator.expects(:create).once
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
|
|
it "doesn't send a message if user was created less than pending_users_reminder_delay minutes ago" do
|
|
SiteSetting.pending_users_reminder_delay_minutes = 8
|
|
user = Fabricate(:user, created_at: 2.minutes.ago)
|
|
Fabricate(:reviewable_user, target: user, created_by: Discourse.system_user)
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
|
|
it "doesn't send a message if pending_users_reminder_delay is -1" do
|
|
SiteSetting.pending_users_reminder_delay_minutes = -1
|
|
user = Fabricate(:user, created_at: 24.hours.ago)
|
|
Fabricate(:reviewable_user, target: user, created_by: Discourse.system_user)
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
|
|
it "sets the correct pending user count in the notification" do
|
|
SiteSetting.pending_users_reminder_delay_minutes = 8
|
|
user = Fabricate(:user, created_at: 9.minutes.ago)
|
|
Fabricate(:reviewable_user, target: user, created_by: Discourse.system_user)
|
|
PostCreator.expects(:create).with(
|
|
Discourse.system_user,
|
|
has_entries(title: "1 user waiting for approval"),
|
|
)
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
end
|
|
|
|
context "when a pending user's reviewable has been rejected" do
|
|
fab!(:moderator) { Fabricate(:moderator, approved: true, approved_by_id: -1) }
|
|
|
|
it "does not send a notification" do
|
|
SiteSetting.pending_users_reminder_delay_minutes = 0
|
|
user = Fabricate(:user, active: true, approved: false)
|
|
Fabricate(:post, user: user)
|
|
reviewable = Fabricate(:reviewable_user, target: user, created_by: Discourse.system_user)
|
|
reviewable.perform(moderator, :delete_user, reject_reason: "spam")
|
|
|
|
expect(reviewable.reload).to be_rejected
|
|
expect(user.reload.approved).to eq(false)
|
|
expect(user.active).to eq(true)
|
|
expect(Reviewable.list_for(moderator, status: :pending)).to be_empty
|
|
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
|
|
expect(Topic.find_by(subtype: TopicSubtype.pending_users_reminder)).to be_nil
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when must_approve_users is false" do
|
|
before { SiteSetting.must_approve_users = false }
|
|
|
|
it "doesn't send a message to anyone when there are pending users" do
|
|
AdminUserIndexQuery.any_instance.stubs(:find_users_query).returns(stub_everything(count: 1))
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
end
|
|
end
|
