mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-07 10:56:41 +08:00
72e4e53fda
# Hide IP Addresses from Moderators When `moderators_view_ips` is Disabled ## Summary Feature Request Link - https://meta.discourse.org/t/option-to-hide-ip-addresses-from-moderators/207715/51 This PR implements a feature to **hide IP addresses from moderators** when the `moderators_view_ips` site setting is disabled. Previously, moderators could view IPs in multiple locations across the admin UI. This update ensures that IP addresses are visible to moderators when the setting allows it. ## Changes Implemented ### Backend Updates - **Added `moderators_view_ips` site setting** in `site_settings.yml` - **Updated `CurrentUserSerializer`** to include `can_see_ip` field based on the user’s role and site setting. - **Modified `AdminUserSerializer`** to restrict IP address visibility. - **Updated `UsersController`** to prevent IP addresses from being included in API responses. - **Restricted IPs in `ScreenedIpAddressesController`** by throwing `Discourse::InvalidAccess` if the user lacks permission. ### Frontend Updates - **Hid "Screened IPs" tab** in `/admin/logs` when `moderators_view_ips` is disabled. - **Blocked direct access to `/admin/logs/screened_ip_addresses`** for unauthorized users. - **Updated `user-index.hbs` and `logs.hbs`** to conditionally hide IP fields. ### UI Screenshots New option for Admins in the Admin Security settings dashboard:  Moderator's view before:  Moderator's view after:  Moderator's view before:  Moderator's view after:  --------- Co-authored-by: Bennett Dungan <bennettdungan@gmail.com> |
||
|---|---|---|
| .. | ||
| concerns | ||
| about_serializer_spec.rb | ||
| admin_detailed_user_serializer_spec.rb | ||
| admin_plugin_serializer_spec.rb | ||
| admin_user_action_serializer_spec.rb | ||
| admin_user_list_serializer_spec.rb | ||
| basic_group_serializer_spec.rb | ||
| basic_group_user_serializer_spec.rb | ||
| basic_post_serializer_spec.rb | ||
| basic_reviewable_flagged_post_serializer_spec.rb | ||
| basic_reviewable_queued_post_serializer_spec.rb | ||
| basic_reviewable_serializer_spec.rb | ||
| basic_reviewable_user_serializer_spec.rb | ||
| basic_topic_serializer_spec.rb | ||
| basic_user_serializer_spec.rb | ||
| category_detailed_serializer_spec.rb | ||
| category_serializer_spec.rb | ||
| category_upload_serializer_spec.rb | ||
| component_index_serializer_spec.rb | ||
| current_user_serializer_spec.rb | ||
| detailed_user_badge_serializer_spec.rb | ||
| directory_item_serializer_spec.rb | ||
| emoji_serializer_spec.rb | ||
| flag_serializer_spec.rb | ||
| found_user_serializer_spec.rb | ||
| group_show_serializer_spec.rb | ||
| group_user_serializer_spec.rb | ||
| group_user_with_custom_fields_serializer_spec.rb | ||
| invite_serializer_spec.rb | ||
| listable_topic_serializer_spec.rb | ||
| new_post_result_serializer_spec.rb | ||
| notification_serializer_spec.rb | ||
| pending_post_serializer_spec.rb | ||
| post_action_type_serializer_spec.rb | ||
| post_localization_serializer_spec.rb | ||
| post_revision_serializer_spec.rb | ||
| post_serializer_spec.rb | ||
| poster_serializer_spec.rb | ||
| remote_theme_serializer_spec.rb | ||
| reviewable_claimed_topic_serializer_spec.rb | ||
| reviewable_flagged_post_serializer_spec.rb | ||
| reviewable_note_serializer_spec.rb | ||
| reviewable_queued_post_serializer_spec.rb | ||
| reviewable_score_serializer_spec.rb | ||
| reviewable_serializer_spec.rb | ||
| reviewable_user_serializer_spec.rb | ||
| single_sign_on_record_serializer_spec.rb | ||
| site_serializer_spec.rb | ||
| suggested_topic_serializer_spec.rb | ||
| tag_group_serializer_spec.rb | ||
| tag_serializer_spec.rb | ||
| theme_index_serializer_spec.rb | ||
| theme_objects_setting_metadata_serializer_spec.rb | ||
| theme_serializer_spec.rb | ||
| theme_settings_serializer_spec.rb | ||
| topic_link_serializer_spec.rb | ||
| topic_list_item_serializer_spec.rb | ||
| topic_list_serializer_spec.rb | ||
| topic_tracking_state_item_serializer_spec.rb | ||
| topic_tracking_state_serializer_spec.rb | ||
| topic_view_details_serializer_spec.rb | ||
| topic_view_posts_serializer_spec.rb | ||
| topic_view_serializer_spec.rb | ||
| upload_serializer_spec.rb | ||
| user_auth_token_serializer_spec.rb | ||
| user_badge_serializer_spec.rb | ||
| user_bookmark_list_serializer_spec.rb | ||
| user_card_serializer_spec.rb | ||
| user_export_serializer_spec.rb | ||
| user_notification_total_serializer_spec.rb | ||
| user_post_bookmark_serializer_spec.rb | ||
| user_serializer_spec.rb | ||
| user_status_serializer_spec.rb | ||
| user_summary_serializer_spec.rb | ||
| user_with_custom_fields_serializer_spec.rb | ||
| web_hook_post_serializer_spec.rb | ||
| web_hook_topic_view_serializer_spec.rb | ||
| web_hook_user_serializer_spec.rb | ||
| wizard_serializer_spec.rb | ||
