Exact

Exact Union RegExp

benj 72e4e53fda FEATURE: add option to hide IP addresses from moderators (#33682) ... # Hide IP Addresses from Moderators When `moderators_view_ips` is Disabled ## Summary Feature Request Link - https://meta.discourse.org/t/option-to-hide-ip-addresses-from-moderators/207715/51 This PR implements a feature to **hide IP addresses from moderators** when the `moderators_view_ips` site setting is disabled. Previously, moderators could view IPs in multiple locations across the admin UI. This update ensures that IP addresses are visible to moderators when the setting allows it. ## Changes Implemented ### Backend Updates - **Added `moderators_view_ips` site setting** in `site_settings.yml` - **Updated `CurrentUserSerializer`** to include `can_see_ip` field based on the user’s role and site setting. - **Modified `AdminUserSerializer`** to restrict IP address visibility. - **Updated `UsersController`** to prevent IP addresses from being included in API responses. - **Restricted IPs in `ScreenedIpAddressesController`** by throwing `Discourse::InvalidAccess` if the user lacks permission. ### Frontend Updates - **Hid "Screened IPs" tab** in `/admin/logs` when `moderators_view_ips` is disabled. - **Blocked direct access to `/admin/logs/screened_ip_addresses`** for unauthorized users. - **Updated `user-index.hbs` and `logs.hbs`** to conditionally hide IP fields. ### UI Screenshots New option for Admins in the Admin Security settings dashboard:  Moderator's view before:  Moderator's view after:  Moderator's view before:  Moderator's view after:  --------- Co-authored-by: Bennett Dungan <bennettdungan@gmail.com>		2025-08-05 10:09:02 -05:00
..
admin	DEV: add text area option to custom user fields (#34072)	2025-08-04 22:12:37 +02:00
api	FEATURE: add option to hide IP addresses from moderators (#33682)	2025-08-05 10:09:02 -05:00
examples	SECURITY: Impose a upper bound on limit params in various controllers	2023-07-28 12:53:46 +01:00
about_controller_spec.rb	FIX: crawler view with unicode usernames (#27051)	2024-05-16 17:11:24 +02:00
application_controller_spec.rb	UX: fix category badges on 404 page and oneboxes (#34071)	2025-08-04 14:02:51 -04:00
associate_accounts_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
badges_controller_spec.rb	DEV: Allow fab! without block (#24314)	2023-11-09 16:47:59 -06:00
bookmarks_controller_spec.rb	DEV: Call Discourse.redis.flushdb after the end of each test (#29117)	2024-10-09 07:19:31 +08:00
categories_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
clicks_controller_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
composer_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
composer_messages_controller_spec.rb	DEV: remove educational tips and associated site settings (#33012)	2025-06-03 09:44:35 +04:00
csp_reports_controller_spec.rb	DEV: Don’t replace Rails logger in specs (#29721)	2024-11-13 08:47:39 +08:00
default_headers_spec.rb	DEV: Disallow the use of Rails.logger= in RSpec tests (#31920)	2025-03-21 08:48:38 +08:00
directory_columns_controller_spec.rb	DEV: Allow fab! without block (#24314)	2023-11-09 16:47:59 -06:00
directory_items_controller_spec.rb	FIX: Allow user directory searches to return more than 20 matching results (#31032)	2025-01-29 11:02:42 -04:00
discourse_id_controller_spec.rb	DEV: Add validator for enable_discourse_id setting (#33710)	2025-07-21 08:18:36 -04:00
do_not_disturb_controller_spec.rb	DEV: Allow fab! without block (#24314)	2023-11-09 16:47:59 -06:00
drafts_controller_spec.rb	FIX: corrently handle hidden tags when checking for edit conflicts	2024-12-09 19:17:16 +01:00
edit_directory_columns_controller_spec.rb	DEV: Allow fab! without block (#24314)	2023-11-09 16:47:59 -06:00
email_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
embed_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
emojis_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
exceptions_controller_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
export_csv_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
extra_locales_controller_spec.rb	DEV: Switch to type="module" for translation files (#33126)	2025-06-09 13:13:42 +01:00
finish_installation_controller_spec.rb	DEV: Improve error message when test fails (#25067)	2023-12-29 12:44:41 +08:00
form_templates_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
forums_controller_spec.rb	FIX: improve "read only" modes (#33521)	2025-07-10 09:08:00 +02:00
groups_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
hashtags_controller_spec.rb	DEV: add tag hashtag data source style type (#33289)	2025-06-20 18:08:47 +04:00
highlightjs_controller_spec.rb	DEV: Simplify CORS logic for public asset routes (#33106)	2025-06-09 08:58:27 +01:00
home_page_controller_spec.rb	DEV: Add site description to crawler homepage view (#32845)	2025-05-22 08:33:59 +10:00
inline_onebox_controller_spec.rb	SECURITY: Limit /inline-onebox to 10 URLs at a time	2025-02-04 13:32:53 -03:00
invites_controller_spec.rb	FIX: Show bulk removal of expired invites (#33716)	2025-07-21 17:13:06 +08:00
list_controller_spec.rb	DEV: Upgrade Rails to version 8.0.2	2025-07-22 09:59:44 +02:00
metadata_controller_spec.rb	FEATURE: sharing link to PWA renders url in title in new Topic to leverage core link expansion (#32631)	2025-06-13 11:25:13 -03:00
net_http_header_spec.rb	DEV: Add a user agent to all HTTP requests that Discourse makes. (#31555)	2025-03-03 16:32:25 +11:00
net_http_timeout_spec.rb	FIX: Set sane default for Net::HTTP when processing a request (#28141)	2024-08-06 07:12:42 +08:00
noscript_escape_spec.rb	SECURITY: Properly escape user content within <noscript>	2024-01-30 09:10:09 -07:00
notifications_controller_spec.rb	FEATURE: Localize topic titles in notifications and bookmarks (#34059)	2025-08-05 12:12:22 +08:00
offline_controller_spec.rb	Add RSpec 4 compatibility (#17652)	2022-07-28 10:27:38 +08:00
omniauth_callbacks_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
onebox_controller_spec.rb	DEV: Allow fab! without block (#24314)	2023-11-09 16:47:59 -06:00
permalinks_controller_spec.rb	FIX: Permalink.create didn't work as expected anymore (#29895)	2024-11-22 21:11:26 +01:00
post_action_users_controller_spec.rb	DEV: Add post_action_users_list modifier for PostActionUsersController (#25740)	2024-02-20 09:48:09 +10:00
post_actions_controller_spec.rb	DEV: Remove full group refreshes from tests (#25414)	2024-01-25 14:28:26 +08:00
post_localizations_controller_spec.rb	DEV: Remove 'experimental' prefix from settings (#33233)	2025-06-19 12:23:42 +08:00
post_readers_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
posts_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
presence_controller_spec.rb	DEV: Call Discourse.redis.flushdb after the end of each test (#29117)	2024-10-09 07:19:31 +08:00
published_pages_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
push_notification_controller_spec.rb	DEV: Allow fab! without block (#24314)	2023-11-09 16:47:59 -06:00
qunit_controller_spec.rb	DEV: Fix broken request/qunit_controller_spec.rb (#32376)	2025-04-21 13:46:25 +08:00
reviewable_claimed_topics_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
reviewable_notes_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
reviewables_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
robots_txt_controller_spec.rb	DEV: Apply syntax_tree formatting to spec/*	2023-01-09 11:49:28 +00:00
safe_mode_controller_spec.rb	DEV: Compile 'common' CSS into own assets (#31416)	2025-05-01 10:44:49 +01:00
search_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
session_controller_spec.rb	SECURITY: Clear webauthn challenge from session after authenticating	2025-07-29 10:40:21 +08:00
sidebar_sections_controller_spec.rb	FIX: Sidebar messages link updates (#33444)	2025-07-07 11:55:39 +08:00
similar_topics_controller_spec.rb	DEV: Remove full group refreshes from tests (#25414)	2024-01-25 14:28:26 +08:00
site_controller_spec.rb	DEV: Introduce stylelint (#29852)	2025-01-20 15:27:42 +00:00
sitemap_controller_spec.rb	DEV: Remove unnecessary rails_helper requiring (#26364)	2024-03-26 11:32:01 +01:00
slugs_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
static_controller_spec.rb	Allow passing a redirect path to a param on the /login route (#32711)	2025-05-15 08:48:06 -05:00
steps_controller_spec.rb	FEATURE: Localize language names (#33790)	2025-07-29 11:48:45 +08:00
stylesheets_controller_spec.rb	DEV: Fix test incorrectly removing stylesheet cache of other processes (#25103)	2024-01-03 13:15:35 +08:00
svg_sprite_controller_spec.rb	DEV: enable raise_error in test envs for deprecated icons in svg_sprite.rb (#30980)	2025-02-04 21:21:20 +08:00
tag_groups_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
tags_controller_spec.rb	FEATURE: Add new edit_tags_allowed_groups setting (#34000)	2025-08-01 15:19:20 +08:00
theme_javascripts_controller_spec.rb	DEV: Use rollup for theme JS compilation (#33103)	2025-07-25 12:02:29 +01:00
topic_localizations_controller_spec.rb	DEV: Remove 'experimental' prefix from settings (#33233)	2025-06-19 12:23:42 +08:00
topic_view_stats_controller_spec.rb	FEATURE: topic_view_stats table with daily fidelity (#27197)	2024-05-27 15:25:32 +10:00
topics_controller_spec.rb	DEV: Prevent N+1 for localizations on topic show (#33674)	2025-07-18 10:53:55 +08:00
uploads_controller_multisite_spec.rb	DEV: Upgrade Rails to version 7.1	2024-07-04 10:58:21 +02:00
uploads_controller_spec.rb	DEV: Add setting to tag s3 objects enabling tag based access control policies (#32988)	2025-06-16 13:26:18 +08:00
user_actions_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
user_api_key_clients_controller_spec.rb	Add user api key client rate limit settings (#30402)	2024-12-30 11:10:48 -05:00
user_api_keys_controller_spec.rb	Require permitted scopes when registering a client (#29718)	2024-11-19 15:28:04 -05:00
user_avatars_controller_spec.rb	FEATURE: reduce avatar sizes to 6 from 20 (#21319)	2023-06-01 10:00:01 +10:00
user_badges_controller_spec.rb	FIX: error when trying to un-favorite badge (#32369)	2025-04-22 15:36:48 +08:00
user_status_controller_spec.rb	DEV: discourse-emojis gem (#31408)	2025-03-03 13:09:08 +01:00
users_controller_spec.rb	FEATURE: Localize topic titles in notifications and bookmarks (#34059)	2025-08-05 12:12:22 +08:00
users_email_controller_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
webhooks_controller_spec.rb	FIX: improve "read only" modes (#33521)	2025-07-10 09:08:00 +02:00
wizard_controller_spec.rb	DEV: Fix various spec linting issues (#24672)	2023-12-04 13:45:19 +01:00