mirror of
https://github.com/discourse/discourse.git
synced 2026-08-08 17:53:55 +08:00
b8077beba5Previously, a tag whose only usage was in personal messages was silently dropped by `TagsController.tag_counts_json` — a display rule from 2020 meant to keep such tags off the `/tags` browse page for users who cannot tag messages (and `pm_tags_allowed_for_groups` has no staff bypass, so by default that includes admins). Every surface reusing that method as a plain serializer inherited the rule by accident: - the composer tag search treated the missing row as unauthorized and showed the tag disabled with a bogus **"Can't be used in this category"** reason (the reported bug), - every "show all tags" chooser (tag groups, synonyms, watched tags, category allowed tags, webhooks, automations, …) silently refused to offer such tags at all, - the `#` autocomplete would not suggest a tag that nonetheless cooked into a working hashtag link when typed in full. This change makes `tag_counts_json` a pure serializer and moves the rule into an explicit, named helper (`DiscourseTagging.without_pm_only_tags`) applied only where it belongs — the `/tags` browse lists — with an exemption for the admin "show all tags" view so the admin inventory is complete. Selection and search surfaces now offer every tag the user is allowed to use, and tag-group visibility rules still apply everywhere. It also fixes two adjacent inconsistencies uncovered along the way: - **Topic→message conversion counter drift.** Converting only adjusted `public_topic_count`, so a converted topic's tags kept working until the periodic consistency job recounted them into the broken state — the "worked at first, broke a day later" in the report. The converter now moves all three counters immediately, and rolls back cleanly when the underlying post revision fails (its return value was previously ignored, and `Topic#valid?` clears the errors it adds, so a failed conversion still applied its side effects). - **Crawler/print tag leak.** The crawler layout leaked a message's tag names in the page title and `og:article:tag` metadata to participants the serializer already hides tags from; both now flow through `TopicView#visible_tags`, gated on `guardian.can_see_tags?`. Reported in https://meta.discourse.org/t/407050 |
||
|---|---|---|
| .. | ||
| access_control_list | ||
| admin/search | ||
| admin_notices | ||
| categories | ||
| category | ||
| custom_emoji | ||
| discourse_id | ||
| email_login_code | ||
| flags | ||
| groups | ||
| nested_topic | ||
| notification/action | ||
| notifications | ||
| problem_check | ||
| site_setting | ||
| site_setting_localizations/about_config | ||
| tags | ||
| themes | ||
| upcoming_changes | ||
| user | ||
| user_api_key | ||
| video_conversion | ||
| access_control_list_manager_spec.rb | ||
| admin_dashboard_engagement_spec.rb | ||
| admin_dashboard_highlights_spec.rb | ||
| admin_dashboard_search_spec.rb | ||
| admin_dashboard_section_configuration_spec.rb | ||
| admin_dashboard_section_loader_spec.rb | ||
| admin_dashboard_site_traffic_spec.rb | ||
| anonymous_shadow_creator_spec.rb | ||
| auto_silence_spec.rb | ||
| badge_granter_spec.rb | ||
| base_bookmarkable_spec.rb | ||
| category_hashtag_data_source_spec.rb | ||
| color_scheme_revisor_spec.rb | ||
| destroy_task_spec.rb | ||
| email_settings_exception_handler_spec.rb | ||
| email_settings_validator_spec.rb | ||
| email_style_updater_spec.rb | ||
| external_upload_manager_spec.rb | ||
| flag_sockpuppets_spec.rb | ||
| group_action_logger_spec.rb | ||
| group_mentions_updater_spec.rb | ||
| group_message_spec.rb | ||
| hashtag_autocomplete_service_spec.rb | ||
| heat_settings_updater_spec.rb | ||
| hub_push_notification_pusher_spec.rb | ||
| inline_uploads_multisite_spec.rb | ||
| inline_uploads_spec.rb | ||
| list_admin_categories_spec.rb | ||
| locale_normalizer_spec.rb | ||
| notification_emailer_spec.rb | ||
| post_action_notifier_spec.rb | ||
| post_alerter_spec.rb | ||
| post_bookmarkable_spec.rb | ||
| post_owner_changer_spec.rb | ||
| problem_check_spec.rb | ||
| push_notification_pusher_spec.rb | ||
| random_topic_selector_spec.rb | ||
| search_indexer_spec.rb | ||
| sidebar_section_updater_spec.rb | ||
| sidebar_site_settings_backfiller_spec.rb | ||
| site_settings_spec.rb | ||
| staff_action_logger_spec.rb | ||
| tag_hashtag_data_source_spec.rb | ||
| tag_settings_updater_spec.rb | ||
| theme_settings_migrations_runner_spec.rb | ||
| themes_spec.rb | ||
| topic_bookmarkable_spec.rb | ||
| topic_status_updater_spec.rb | ||
| topic_timestamp_changer_spec.rb | ||
| trust_level_granter_spec.rb | ||
| user_activator_spec.rb | ||
| user_anonymizer_spec.rb | ||
| user_authenticator_spec.rb | ||
| user_destroyer_spec.rb | ||
| user_merger_spec.rb | ||
| user_notification_schedule_processor_spec.rb | ||
| user_password_expirer_spec.rb | ||
| user_silencer_spec.rb | ||
| user_stat_count_updater_spec.rb | ||
| user_suspender_spec.rb | ||
| user_updater_spec.rb | ||
| username_changer_spec.rb | ||
| username_checker_service_spec.rb | ||
| wildcard_domain_checker_spec.rb | ||
| wildcard_url_checker_spec.rb | ||
| word_watcher_spec.rb | ||
