mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-27 03:26:21 +08:00
7cf28fec7b
This optimizes a hot path when users are being removed from one or more groups since we use the `on(:user_removed_from_group)` event to call the `Chat::AutoLeaveChannels` with a `user_id` parameter. In such case, we don't need to clear the membership of all users, just that one user. DEBUG: Also added a "-- event = <event>" comment on top of the SQL queries used by the "AutoLeaveChannels" so they show up in the logs and hopefully facilitate any performance issues that might arise in the future.
89 lines
2.9 KiB
Ruby
Vendored
89 lines
2.9 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
module Chat
|
|
class AutoLeaveChannels
|
|
include Service::Base
|
|
|
|
ALLOWED_GROUP_PERMISSIONS = [
|
|
CategoryGroup.permission_types[:create_post],
|
|
CategoryGroup.permission_types[:full],
|
|
]
|
|
|
|
policy :chat_enabled?
|
|
|
|
params do
|
|
attribute :event
|
|
attribute :user_id, :integer
|
|
attribute :group_id, :integer
|
|
attribute :channel_id, :integer
|
|
attribute :category_id, :integer
|
|
|
|
validates :event, presence: true
|
|
end
|
|
|
|
step :remove_memberships
|
|
|
|
private
|
|
|
|
def chat_enabled?
|
|
SiteSetting.chat_enabled
|
|
end
|
|
|
|
def remove_memberships(params:)
|
|
group_ids = SiteSetting.chat_allowed_groups_map
|
|
group_permissions = ALLOWED_GROUP_PERMISSIONS
|
|
users_removed_map = Hash.new { |h, k| h[k] = [] }
|
|
|
|
if !group_ids.include?(Group::AUTO_GROUPS[:everyone])
|
|
sql = <<~SQL
|
|
-- event = #{params.event}
|
|
DELETE FROM user_chat_channel_memberships uccm
|
|
WHERE NOT EXISTS (
|
|
SELECT 1
|
|
FROM group_users gu
|
|
WHERE gu.user_id = uccm.user_id
|
|
AND gu.group_id IN (:group_ids)
|
|
)
|
|
#{params.user_id ? "AND uccm.user_id = #{params.user_id}" : ""}
|
|
RETURNING chat_channel_id, user_id
|
|
SQL
|
|
|
|
DB
|
|
.query_array(sql, group_ids:)
|
|
.each { |channel_id, user_id| users_removed_map[channel_id] << user_id }
|
|
end
|
|
|
|
user_sql = params.user_id ? "AND u.id = #{params.user_id}" : ""
|
|
channel_sql = params.channel_id ? "AND cc.id = #{params.channel_id}" : ""
|
|
category_sql = params.category_id ? "AND c.id = #{params.category_id}" : ""
|
|
|
|
sql = <<~SQL
|
|
-- event = #{params.event}
|
|
WITH valid_permissions AS (
|
|
SELECT gu.user_id, cg.category_id
|
|
FROM group_users gu
|
|
JOIN category_groups cg ON cg.group_id = gu.group_id AND cg.permission_type IN (:group_permissions)
|
|
)
|
|
DELETE FROM user_chat_channel_memberships
|
|
WHERE (user_id, chat_channel_id) IN (
|
|
SELECT uccm.user_id, uccm.chat_channel_id
|
|
FROM user_chat_channel_memberships uccm
|
|
JOIN users u ON u.id = uccm.user_id AND u.id > 0 AND u.moderator = FALSE AND u.admin = FALSE #{user_sql}
|
|
JOIN chat_channels cc ON cc.id = uccm.chat_channel_id AND cc.chatable_type = 'Category' #{channel_sql}
|
|
JOIN categories c ON c.id = cc.chatable_id AND c.read_restricted = TRUE #{category_sql}
|
|
LEFT JOIN valid_permissions vp ON vp.user_id = uccm.user_id AND vp.category_id = c.id
|
|
WHERE vp.user_id IS NULL
|
|
)
|
|
RETURNING chat_channel_id, user_id
|
|
SQL
|
|
|
|
DB
|
|
.query_array(sql, group_permissions:)
|
|
.each { |channel_id, user_id| users_removed_map[channel_id] << user_id }
|
|
|
|
if users_removed_map.present?
|
|
Chat::Action::PublishAutoRemovedUser.call(event: params.event, users_removed_map:)
|
|
end
|
|
end
|
|
end
|
|
end
|
