Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-05-21 19:12:39 +08:00
Code Packages Activity Actions
discourse/spec/lib/file_store
History
Exact
Alan Guo Xiang Tan 342e9208b3
FIX: Upload#update_secure_status not updating s3 access control (#33232) 
This commit is a follow-up to b02bc707de
where `Upload#update_secure_status` does not call
`FileStore::S3Store#update_upload_access_control` if
`s3_use_acls` is disabled. This is no longer correct as an upload's
access control on S3 can now be based on tags if the
`s3_enable_access_control_tags` site setting is
enabled.

To fix this, this commit removes the `s3_use_acls` check in
`Upload#update_secure_status` and updates
`FileStore::S3Store#default_s3_options`
to not set the `acl` option if the `s3_use_acls` site setting is
disabled.
2025-06-17 16:28:36 +08:00
..
base_store_spec.rb DEV: Add both safe and unsafe Discourse.store.download methods (#21498) 2023-05-11 17:27:27 +08:00
local_store_spec.rb DEV: Allow fab! without block (#24314) 2023-11-09 16:47:59 -06:00
s3_store_spec.rb FIX: Upload#update_secure_status not updating s3 access control (#33232) 2025-06-17 16:28:36 +08:00