mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
d2dc8d4f22b1399d6a6f removed the last mobile/desktop-specific CSS from Discourse.
Everything is now handled by media queries in common scss.
This commit drops the mobile/desktop stylesheet infrastructure for core.
It remains in place for themes & plugins.
Much of the diff is updating specs to avoid mobile/desktop as fixtures,
and to remove argument defaults which no longer make sense.
89 lines
3.2 KiB
Ruby
Vendored
89 lines
3.2 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
require "stylesheet/watcher"
|
|
|
|
RSpec.describe Stylesheet::Watcher do
|
|
subject(:watcher) { described_class.new([]) }
|
|
|
|
describe "#path_data" do
|
|
it "does not infer a core target from the filename" do
|
|
path =
|
|
Rails.root.join("app/assets/stylesheets/common/components/admin-onboarding-banner.scss")
|
|
|
|
expect(watcher.path_data(path.to_s, [])).to include(target: nil, plugin_name: nil)
|
|
end
|
|
|
|
it "infers core targets from stylesheet directories" do
|
|
path = Rails.root.join("app/assets/stylesheets/admin/dashboard.scss")
|
|
|
|
expect(watcher.path_data(path.to_s, [])).to include(target: "admin", plugin_name: nil)
|
|
end
|
|
|
|
it "infers core targets from top-level stylesheet filenames" do
|
|
path = Rails.root.join("app/assets/stylesheets/wizard.scss")
|
|
|
|
expect(watcher.path_data(path.to_s, [])).to include(target: "wizard", plugin_name: nil)
|
|
end
|
|
|
|
it "infers special core targets from top-level filenames" do
|
|
path = Rails.root.join("app/assets/stylesheets/color_definitions.scss")
|
|
|
|
expect(watcher.path_data(path.to_s, [])).to include(
|
|
target: "color_definitions",
|
|
plugin_name: nil,
|
|
)
|
|
end
|
|
|
|
it "infers plugin names from stylesheet paths under plugins" do
|
|
plugin_path = Rails.root.join("plugins/discourse-calendar").to_s
|
|
path = Rails.root.join("plugins/discourse-calendar/assets/stylesheets/admin/calendar.scss")
|
|
|
|
expect(watcher.path_data(path.to_s, [plugin_path])).to include(
|
|
target: nil,
|
|
plugin_name: "discourse-calendar",
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "#plugin_assets_refresh" do
|
|
let(:plugin_name) { "test-plugin" }
|
|
let(:manager) { instance_double(Stylesheet::Manager) }
|
|
|
|
before do
|
|
DiscoursePluginRegistry.stylesheets[plugin_name] = Set.new(["stylesheets/common.scss"])
|
|
DiscoursePluginRegistry.desktop_stylesheets[plugin_name] = Set.new(
|
|
["stylesheets/desktop.scss"],
|
|
)
|
|
DiscoursePluginRegistry.mobile_stylesheets[plugin_name] = Set.new(["stylesheets/mobile.scss"])
|
|
DiscoursePluginRegistry.admin_stylesheets[plugin_name] = Set.new(["stylesheets/admin.scss"])
|
|
|
|
allow(Stylesheet::Manager).to receive(:new).and_return(manager)
|
|
allow(manager).to receive(:stylesheet_data) do |target|
|
|
[{ target: target, new_href: "/stylesheets/#{target}.css" }]
|
|
end
|
|
end
|
|
|
|
after { DiscoursePluginRegistry.reset! }
|
|
|
|
it "publishes changes for every registered plugin target" do
|
|
messages =
|
|
MessageBus.track_publish("/file-change") { watcher.plugin_assets_refresh(plugin_name) }
|
|
|
|
expect(messages.first.data).to contain_exactly(
|
|
{ target: :"test-plugin", new_href: "/stylesheets/test-plugin.css" },
|
|
{ target: :"test-plugin_desktop", new_href: "/stylesheets/test-plugin_desktop.css" },
|
|
{ target: :"test-plugin_mobile", new_href: "/stylesheets/test-plugin_mobile.css" },
|
|
{ target: :"test-plugin_admin", new_href: "/stylesheets/test-plugin_admin.css" },
|
|
)
|
|
end
|
|
|
|
it "skips publishing when the plugin has no registered stylesheets" do
|
|
DiscoursePluginRegistry.reset!
|
|
|
|
messages =
|
|
MessageBus.track_publish("/file-change") { watcher.plugin_assets_refresh(plugin_name) }
|
|
|
|
expect(messages).to be_empty
|
|
end
|
|
end
|
|
end
|
