mirror of
https://github.com/discourse/discourse.git
synced 2026-08-08 17:53:55 +08:00
2fb976fab1Dropbox has introduced a new sharing URL format using `/scl/fi/` instead of the legacy `/s/` path. This updates VideoOnebox and ImageOnebox to: - Detect and transform new `/scl/` format URLs - Convert to dl.dropboxusercontent.com domain - Ensure raw=1 parameter is present for direct download - Maintain backward compatibility with legacy `/s/` format - Also...added test coverage for both old and new Dropbox formats. All existing tests continue to pass. Co-Authored-By: Claude Sonnet 4.5 --------- Co-authored-by: Loïc Guitaut <loic@discourse.org>
60 lines
1.7 KiB
Ruby
Vendored
60 lines
1.7 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe Onebox::Engine::VideoOnebox do
|
|
it "supports ogv" do
|
|
expect(
|
|
Onebox.preview(
|
|
"http://upload.wikimedia.org/wikipedia/commons/3/37/STS-134_launch_2.ogv",
|
|
).to_s,
|
|
).to match(/<video/)
|
|
end
|
|
|
|
it "supports mp4" do
|
|
expect(Onebox.preview("http://download.wavetlan.com/svv/dev/test.mp4").to_s).to match(/<video/)
|
|
end
|
|
|
|
it "supports mov" do
|
|
expect(
|
|
Onebox.preview("http://download.wavetlan.com/SVV/Media/HTTP/BlackBerry.MOV").to_s,
|
|
).to match(/<video/)
|
|
end
|
|
|
|
it "supports webm" do
|
|
expect(Onebox.preview("http://video.webmfiles.org/big-buck-bunny_trailer.webm").to_s).to match(
|
|
/<video/,
|
|
)
|
|
end
|
|
|
|
it "supports URLs with query parameters" do
|
|
expect(
|
|
Onebox.preview("http://video.webmfiles.org/big-buck-bunny_trailer.webm?foo=bar").to_s,
|
|
).to match(/<video/)
|
|
end
|
|
|
|
it "supports protocol relative URLs" do
|
|
expect(Onebox.preview("//video.webmfiles.org/big-buck-bunny_trailer.webm").to_s).to match(
|
|
/<video/,
|
|
)
|
|
end
|
|
|
|
it "includes a fallback direct link to the video" do
|
|
expect(Onebox.preview("http://download.wavetlan.com/svv/dev/test.mp4").to_s).to match(/<a.*mp4/)
|
|
end
|
|
|
|
it "respects the disable_media_download_controls option" do
|
|
expect(
|
|
Onebox.preview(
|
|
"http://download.wavetlan.com/svv/dev/test.mp4",
|
|
disable_media_download_controls: true,
|
|
).to_s,
|
|
).to include("controlslist=\"nodownload\"")
|
|
end
|
|
|
|
context "with Dropbox URL" do
|
|
let(:html) { Onebox.preview("https://www.dropbox.com/scl/fi/abc123/video.mp4?rlkey=xyz").to_s }
|
|
|
|
it "transforms to direct download link" do
|
|
expect(html).to include("dl.dropboxusercontent.com")
|
|
end
|
|
end
|
|
end
|
