discourse/spec
David Battersby 793c55aa58
FIX: composer educational limit should use post count (#33650)
The educational posts site setting (`educate_until_posts`) feels buggy,
this is because the logic for showing these messages treats topics and
replies (posts) as a separate count.

If `SiteSetting.educate_until_posts` has a value of 2, the user can
write multiple replies to existing topics and see the "Welcome to our
community! You are brand new here..." message for the first 2 times then
it will not show again.

However, once they decide to create a topic they will see the message
again which doesn't feel right.

The solution is to use a combined count (`user.topic_count` and
`user.post_count`) and check against the site setting value. That way we
don't double up educational messages for both topics and replies when
using composer.
2025-07-17 18:15:18 +04:00
..
db/migrate FEATURE: Themeable site settings (#32233) 2025-07-16 11:00:21 +10:00
fabricators FEATURE: Themeable site settings (#32233) 2025-07-16 11:00:21 +10:00
fixtures FIX: correctly unescape title for amazon oneboxes (#33010) 2025-06-02 17:50:13 +05:30
generator DEV: Silence the output of migration specs (#26365) 2024-03-26 11:32:44 +01:00
helpers DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
import_export DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
initializers DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
integration DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
integrity FIX: cross origin opener policy should apply to public error responses (#31559) 2025-03-03 17:04:24 +08:00
jobs DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
lib FIX: composer educational limit should use post count (#33650) 2025-07-17 18:15:18 +04:00
mailers DEV: Remove ability to use users' names in group mention notifications and mentions shown in emails and added :user_notification_email_options plugin modifier to allow plugins reintroduce this or other modifications to emails (#33449) 2025-07-14 15:20:08 -05:00
models FIX: Catch syntax errors in raw scripts (#33673) 2025-07-17 13:24:27 +01:00
multisite FEATURE: Themeable site settings (#32233) 2025-07-16 11:00:21 +10:00
queries/reports DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
requests DEV: Extract theme script tags into their own JS files (#33647) 2025-07-16 17:17:36 +01:00
script/import_scripts DEV: Catch missing translations during test runs (#26258) 2024-05-24 22:15:53 +08:00
serializers DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577) 2025-07-11 11:16:34 -03:00
services FEATURE: Themeable site settings (#32233) 2025-07-16 11:00:21 +10:00
support FEATURE: Themeable site settings (#32233) 2025-07-16 11:00:21 +10:00
system UX: add welcome banner location site setting to admin interface (#33438) 2025-07-17 13:34:22 +08:00
tasks DEV: remove deduplicate horizon script (#33595) 2025-07-14 14:34:47 +08:00
views FIX: correctly displaying the failure error message 2025-06-25 10:25:41 +08:00
rails_helper.rb FEATURE: Themeable site settings (#32233) 2025-07-16 11:00:21 +10:00
regenerate_swagger_docs DEV: Add API docs for uploads and API doc watcher (#15387) 2021-12-23 08:40:15 +10:00
swagger_helper.rb DEV: Bump rswag-specs from 2.11.0 to 2.13.0 (#24654) 2023-12-07 08:16:47 +08:00