mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
## Summary Reports have surfaced of posts that lock up or crash browsers when their topic loads, even though the raw is well within `max_post_length`. The trigger is many `[quote=...]` BBCode openers per post — typically unbalanced with the matching `[/quote]` closers. When the BBCode block rule can't pair them up, each opener falls through to inline parsing and cooks into its own `<p>[quote=...]</p>` paragraph. Posts with hundreds to thousands of these paragraphs are cheap to author but expensive to render: thousands of DOM nodes, per-post decoration passes (quote-back links, MutationObservers, oneboxer, etc.) running once per fragment, and post-level event handlers all compound. Examples in the wild have raws of 11–47 KB containing 220–880 `[quote=` openers, cooking into 25–100 KB of near-identical paragraphs. None of these come close to `max_post_length`, so the existing length validator never fires. This adds a `max_quotes_per_post` site setting (default `50`, set to `0` to disable). `PostValidator` rejects any post whose raw contains more `[quote=` / `[quote]` openers than the limit. ## Notes - The default of 50 is well above any realistic legitimate use (deeply nested quote-replies in practice top out around 5–10 levels). The four observed offender posts contain 220, 220, 660, and 880 `[quote=` openers — all rejected at the default. - Counts openers only (`[quote=` and `[quote]`, case-insensitive), not balanced pairs. The DoS comes from openers; closers are cheap. - Existing offending posts on affected sites still need to be deleted/rebaked manually — this only stops new ones. ## Test plan - [x] `bin/rspec spec/lib/validators/post_validator_spec.rb` — all 53 examples pass, including 6 new cases covering: over-limit, at-limit, unbalanced openers, plain `[quote]`, case-insensitivity, and disable-via-zero. - [ ] Manually try to submit a post with 51+ `[quote=...]` lines via the composer and confirm the error message. - [ ] Try the same via the API. - [ ] Confirm legitimate "Quote Reply" workflows (a handful of nested quotes) still work.
245 lines
6.7 KiB
Ruby
Vendored
245 lines
6.7 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
class PostValidator < ActiveModel::Validator
|
|
def validate(record)
|
|
presence(record)
|
|
|
|
return if record.acting_user&.staged?
|
|
return if record.acting_user&.admin? && Discourse.static_doc_topic_ids.include?(record.topic_id)
|
|
|
|
post_body_validator(record)
|
|
max_posts_validator(record)
|
|
unique_post_validator(record)
|
|
|
|
# These validators might cook the post or do SQL queries.
|
|
# So we only run them if the post is otherwise valid.
|
|
if record.errors.empty?
|
|
max_mention_validator(record)
|
|
max_embedded_media_validator(record)
|
|
max_attachments_validator(record)
|
|
max_links_validator(record)
|
|
max_quotes_validator(record)
|
|
force_edit_last_validator(record)
|
|
end
|
|
end
|
|
|
|
def presence(post)
|
|
post.errors.add(:topic_id, :blank, **options) if !options[:skip_topic] && post.topic_id.blank?
|
|
post.errors.add(:user_id, :blank, **options) if post.new_record? && post.user_id.blank?
|
|
end
|
|
|
|
def post_body_validator(post)
|
|
return if options[:skip_post_body]
|
|
|
|
stripped_length(post)
|
|
return if post.topic&.pm_with_non_human_user?
|
|
|
|
raw_quality(post)
|
|
WatchedWordsValidator.new(attributes: [:raw]).validate(post) if !post.acting_user&.staged
|
|
end
|
|
|
|
def stripped_length(post)
|
|
range =
|
|
if post.topic&.pm_with_non_human_user?
|
|
(0..SiteSetting.max_post_length)
|
|
elsif private_message?(post)
|
|
SiteSetting.private_message_post_length
|
|
elsif post.is_first_post? || (post.topic.present? && post.topic.posts_count == 0)
|
|
if post.topic&.featured_link.present?
|
|
(0..SiteSetting.max_post_length)
|
|
else
|
|
SiteSetting.first_post_length
|
|
end
|
|
else
|
|
SiteSetting.post_length
|
|
end
|
|
|
|
StrippedLengthValidator.validate(
|
|
post,
|
|
:raw,
|
|
post.raw,
|
|
range,
|
|
strip_uploads: SiteSetting.prevent_uploads_only_posts,
|
|
)
|
|
end
|
|
|
|
def max_posts_validator(post)
|
|
if post.new_record? && post.acting_user&.posted_too_much_in_topic?(post.topic_id)
|
|
post.errors.add(
|
|
:base,
|
|
I18n.t(:too_many_replies, count: SiteSetting.newuser_max_replies_per_topic),
|
|
)
|
|
end
|
|
end
|
|
|
|
def unique_post_validator(post)
|
|
return if SiteSetting.unique_posts_mins == 0
|
|
return if post.skip_unique_check
|
|
return if post.acting_user&.staff?
|
|
return if post.raw.blank?
|
|
|
|
post.errors.add(:raw, I18n.t(:just_posted_that)) if post.matches_recent_post?
|
|
end
|
|
|
|
def max_mention_validator(post)
|
|
return if post.acting_user&.staff?
|
|
|
|
if acting_user_is_trusted?(post) || private_message?(post)
|
|
add_error_if_count_exceeded(
|
|
post,
|
|
:no_mentions_allowed,
|
|
:too_many_mentions,
|
|
post.raw_mentions.size,
|
|
SiteSetting.max_mentions_per_post,
|
|
)
|
|
else
|
|
add_error_if_count_exceeded(
|
|
post,
|
|
:no_mentions_allowed_newuser,
|
|
:too_many_mentions_newuser,
|
|
post.raw_mentions.size,
|
|
SiteSetting.newuser_max_mentions_per_post,
|
|
)
|
|
end
|
|
end
|
|
|
|
def max_embedded_media_validator(post)
|
|
return if post.acting_user.nil?
|
|
return if post.acting_user.staff?
|
|
|
|
if !post.acting_user.in_any_groups?(SiteSetting.embedded_media_post_allowed_groups_map)
|
|
add_error_if_count_exceeded(
|
|
post,
|
|
:no_embedded_media_allowed_group,
|
|
:no_embedded_media_allowed_group,
|
|
post.embedded_media_count,
|
|
0,
|
|
)
|
|
elsif post.acting_user.trust_level == TrustLevel[0]
|
|
add_error_if_count_exceeded(
|
|
post,
|
|
:no_embedded_media_allowed,
|
|
:too_many_embedded_media,
|
|
post.embedded_media_count,
|
|
SiteSetting.newuser_max_embedded_media,
|
|
)
|
|
end
|
|
end
|
|
|
|
def max_attachments_validator(post)
|
|
return if acting_user_is_trusted?(post) || private_message?(post)
|
|
|
|
add_error_if_count_exceeded(
|
|
post,
|
|
:no_attachments_allowed,
|
|
:too_many_attachments,
|
|
post.attachment_count,
|
|
SiteSetting.newuser_max_attachments,
|
|
)
|
|
end
|
|
|
|
def max_links_validator(post)
|
|
if (post.link_count == 0 && !post.has_oneboxes?) || private_message?(post)
|
|
return newuser_links_validator(post)
|
|
end
|
|
|
|
guardian = Guardian.new(post.acting_user)
|
|
if post.linked_hosts.keys.all? { |h| guardian.can_post_link?(host: h) }
|
|
return newuser_links_validator(post)
|
|
end
|
|
|
|
post.errors.add(:base, I18n.t(:links_require_trust))
|
|
end
|
|
|
|
def max_quotes_validator(post)
|
|
max = SiteSetting.max_quotes_per_post
|
|
return if max <= 0
|
|
|
|
count = post.raw.to_s.scan(/\[quote[=\]]/i).size
|
|
post.errors.add(:base, I18n.t(:too_many_quotes, count: max)) if count > max
|
|
end
|
|
|
|
def force_edit_last_validator(post)
|
|
return if post.id
|
|
return if private_message?(post)
|
|
return if post.acting_user&.staff?
|
|
return if SiteSetting.max_consecutive_replies == 0
|
|
|
|
topic = post.topic
|
|
return if topic&.ordered_posts&.first&.user == post.user
|
|
|
|
guardian = Guardian.new(post.acting_user)
|
|
return if guardian.is_category_group_moderator?(post.topic&.category)
|
|
|
|
last_posts_count =
|
|
DB.query_single(
|
|
<<~SQL,
|
|
SELECT COUNT(*)
|
|
FROM (
|
|
SELECT user_id
|
|
FROM posts
|
|
WHERE deleted_at IS NULL
|
|
AND NOT hidden
|
|
AND topic_id = :topic_id
|
|
ORDER BY post_number DESC
|
|
LIMIT :max_replies
|
|
) c
|
|
WHERE c.user_id = :user_id
|
|
SQL
|
|
topic_id: post.topic_id,
|
|
user_id: post.acting_user.id,
|
|
max_replies: SiteSetting.max_consecutive_replies,
|
|
).first
|
|
return if last_posts_count < SiteSetting.max_consecutive_replies
|
|
|
|
if guardian.can_edit?(topic.ordered_posts.last)
|
|
post.errors.add(
|
|
:base,
|
|
I18n.t(:max_consecutive_replies, count: SiteSetting.max_consecutive_replies),
|
|
)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def raw_quality(post)
|
|
return if TextSentinel.body_sentinel(post.raw, private_message: private_message?(post)).valid?
|
|
post.errors.add(:raw, I18n.t(:is_invalid))
|
|
end
|
|
|
|
def acting_user_is_trusted?(post, level = 1)
|
|
post.acting_user&.has_trust_level?(TrustLevel[level])
|
|
end
|
|
|
|
def private_message?(post)
|
|
post.topic&.private_message? || options[:private_message]
|
|
end
|
|
|
|
def newuser_links_validator(post)
|
|
return if acting_user_is_trusted?(post) || private_message?(post)
|
|
|
|
add_error_if_count_exceeded(
|
|
post,
|
|
:no_links_allowed,
|
|
:too_many_links,
|
|
post.link_count,
|
|
SiteSetting.newuser_max_links,
|
|
)
|
|
end
|
|
|
|
def add_error_if_count_exceeded(
|
|
post,
|
|
not_allowed_translation_key,
|
|
limit_translation_key,
|
|
current_count,
|
|
max_count
|
|
)
|
|
if current_count > max_count
|
|
if max_count == 0
|
|
post.errors.add(:base, I18n.t(not_allowed_translation_key))
|
|
else
|
|
post.errors.add(:base, I18n.t(limit_translation_key, count: max_count))
|
|
end
|
|
end
|
|
end
|
|
end
|