mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-03 18:03:36 +08:00
235c673fe8
This PR adds localized language names to settings. The language names
are localized in the frontend, not the backend, due to setting
initialization complexity.
This change affects these areas:
- `SiteSetting.available_locales`
- this "setting" is a lookup table to get language names. use
`languageNameLookup` service to get the name for a locale
- it returns an object that looks like the following, then gets
re-hydrated with client localized values when initializing the
`siteSettingService` in the frontend.
```
[
{"native_name":"اللغة العربية","value":"ar","name":"languages.ar.name"},
...
]
```
- `SiteSetting.default_locale`
- this is a single-value `enum` setting that has always been hardcoded.
This caused quite an issue as it is not initialized the same way as
other site settings in the yml file. It has always relied on reading
directly from a `names.yml` file to load native language names, thus
bypassing the need for I18n to be initialized from the backend. A new
locale_enum type has been introduced for this setting, and any future
settings.
- `SiteSetting.content_localization_supported_locales` - this is a
`enum_list` setting,
- enum_list is introduced, leveraging both `list` and `enum`
- theme translations
- site texts
- Wizard's default_locale choices
- it was set up from the backend using `LocaleSiteSetting.value`. This
proved problematic, as a Japanese user would be getting the locales in
English because the values are initialized using English even without
memoization
- therefore we're now initializing the choices in the frontend using
`available_locales` as defined above
- content localization meta data
- post language in the composer, localization composer, post history
modal, post language tooltip, language switcher
/t/151409
52 lines
1.4 KiB
Ruby
52 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe StepsController do
|
|
before { SiteSetting.wizard_enabled = true }
|
|
|
|
it "needs you to be logged in" do
|
|
put "/wizard/steps/made-up-id.json", params: { fields: { forum_title: "updated title" } }
|
|
expect(response.status).to eq(403)
|
|
end
|
|
|
|
it "raises an error if you aren't an admin" do
|
|
sign_in(Fabricate(:moderator))
|
|
|
|
put "/wizard/steps/made-up-id.json", params: { fields: { forum_title: "updated title" } }
|
|
|
|
expect(response).to be_forbidden
|
|
end
|
|
|
|
context "as an admin" do
|
|
before { sign_in(Fabricate(:admin)) }
|
|
|
|
it "raises an error if the wizard is disabled" do
|
|
SiteSetting.wizard_enabled = false
|
|
put "/wizard/steps/introduction.json",
|
|
params: {
|
|
fields: {
|
|
contact_email: "eviltrout@example.com",
|
|
},
|
|
}
|
|
expect(response).to be_forbidden
|
|
end
|
|
|
|
it "updates properly if you are staff" do
|
|
put "/wizard/steps/introduction.json",
|
|
params: {
|
|
fields: {
|
|
title: "FooBar",
|
|
default_locale: SiteSetting.default_locale,
|
|
},
|
|
}
|
|
|
|
expect(response.status).to eq(200)
|
|
end
|
|
|
|
it "returns errors if the field has them" do
|
|
title = SiteSetting.title
|
|
put "/wizard/steps/introduction.json", params: { fields: { title: } }
|
|
|
|
expect(response.status).to eq(422)
|
|
end
|
|
end
|
|
end
|
