mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-23 18:23:46 +08:00
17e1bfe069
This commit drops the `before_action :preload_json` callback in `ApplicationController` as it adds unnecessary complexity to `ApplicationController` as well as other controllers which has to skip this callback. The source of the complexity comes mainly from the following two conditionals in the `preload_json` method:
```
# We don't preload JSON on xhr or JSON request
return if request.xhr? || request.format.json?
# if we are posting in makes no sense to preload
return if request.method != "GET"
```
Basically, the conditionals solely exists for optimization purposes to ensure that we don't run the preloading code when the request is not a GET request and the response is not expected to be HTML. The key problem here is that the conditionals are trying to expect what the content type of the response will be and this has proven to be hard to get right. Instead, we can simplify this problem by running the preloading code in a more deterministic way which is to preload only when the `application` layout is being rendered and this is main change that this commit introduces.
|
||
|---|---|---|
| .. | ||
| config | ||
| admin_controller_spec.rb | ||
| api_controller_spec.rb | ||
| backups_controller_spec.rb | ||
| badges_controller_spec.rb | ||
| color_schemes_controller_spec.rb | ||
| dashboard_controller_spec.rb | ||
| email_controller_spec.rb | ||
| email_styles_controller_spec.rb | ||
| email_templates_controller_spec.rb | ||
| embeddable_hosts_controller_spec.rb | ||
| embedding_controller_spec.rb | ||
| emojis_controller_spec.rb | ||
| form_templates_controller_spec.rb | ||
| groups_controller_spec.rb | ||
| impersonate_controller_spec.rb | ||
| permalinks_controller_spec.rb | ||
| plugins_controller_spec.rb | ||
| reports_controller_spec.rb | ||
| robots_txt_controller_spec.rb | ||
| screened_emails_controller_spec.rb | ||
| screened_ip_addresses_controller_spec.rb | ||
| screened_urls_controller_spec.rb | ||
| search_logs_spec.rb | ||
| site_settings_controller_spec.rb | ||
| site_texts_controller_spec.rb | ||
| staff_action_logs_controller_spec.rb | ||
| themes_controller_spec.rb | ||
| user_fields_controller_spec.rb | ||
| users_controller_spec.rb | ||
| versions_controller_spec.rb | ||
| watched_words_controller_spec.rb | ||
| web_hooks_controller_spec.rb | ||
