0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-08 17:53:55 +08:00
discourse/plugins/chat/spec/system/browse_page_spec.rb
Régis Hanol 87f9d907ab
FIX: Handle a member disabling chat in their preferences (#41805)
Previously, a member who turned chat off in their preferences saw their
existing chat notifications render as blank rows, and any chat link
silently bounced them to the homepage.

This change registers the chat notification renderers whenever chat is
enabled site-wide so those notifications still render correctly, and
sends chat links to a new "chat is disabled" page that explains how to
turn it back on.

**BEFORE**

(the notification are "blank")

<img width="1400" height="1200" alt="before-notifications"
src="https://github.com/user-attachments/assets/d8dcef2e-98eb-4b30-bf33-4a1f8c2c4626"
/>

**AFTER**

(the notification are there)

<img width="1400" height="1200" alt="after-notifications"
src="https://github.com/user-attachments/assets/72b17123-8f82-4c5e-a74d-7d5347de623a"
/>

(the "blank slate" page that is displayed when you click a #chat
notification after you've disabled #chat in your preferences)

<img width="1400" height="1200" alt="after-disabled-page"
src="https://github.com/user-attachments/assets/1905ecb5-7b8c-4682-87a9-1559ca4ec569"
/>
2026-07-17 16:21:12 +02:00

230 lines
8.1 KiB
Ruby
Vendored
Raw Permalink Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

# frozen_string_literal: true
RSpec.describe "Browse page" do
fab!(:current_user, :user)
let(:chat_page) { PageObjects::Pages::Chat.new }
let(:browse_page) { PageObjects::Pages::ChatBrowse.new }
before do
sign_in(current_user)
chat_system_bootstrap
end
context "when public channels are disabled" do
before { SiteSetting.enable_public_channels = false }
it "redirects to homepage" do
visit("/chat/browse") # no page object here as we actually don't load it
expect(page).to have_current_path("/latest")
end
end
context "when user has chat enabled" do
context "when visiting browse page" do
it "defaults to open filer" do
chat_page.visit_browse
expect(browse_page).to have_current_path("/chat/browse/open")
end
it "has the expected tabs" do
chat_page.visit_browse
expect(browse_page).to have_channel(name: I18n.t("js.chat.browse.filter_all"))
expect(browse_page).to have_channel(name: I18n.t("js.chat.browse.filter_open"))
expect(browse_page).to have_channel(name: I18n.t("js.chat.browse.filter_closed"))
end
it "has not archived tab available" do
chat_page.visit_browse
expect(browse_page).to have_no_channel(name: I18n.t("js.chat.browse.filter_archived"))
end
it "redirects archived tab to default tab" do
chat_page.visit_browse(:archived)
expect(browse_page).to have_current_path("/chat/browse/open")
end
context "when archiving channels is enabled" do
before { SiteSetting.chat_allow_archiving_channels = true }
it "has the archived tab" do
chat_page.visit_browse
expect(browse_page).to have_channel(name: I18n.t("js.chat.browse.filter_archived"))
end
end
end
context "when on mobile", mobile: true do
it "has a back button" do
chat_page.visit_browse
find(".c-navbar__back-button").click
expect(browse_page).to have_current_path("/chat/channels")
end
end
context "when filtering results" do
fab!(:category_channel_1) { Fabricate(:chat_channel, name: "foo") }
fab!(:category_channel_2) { Fabricate(:chat_channel, name: "bar") }
context "when results are found" do
it "lists expected results" do
chat_page.visit_browse
browse_page.search(category_channel_1.name)
expect(browse_page).to have_channel(name: category_channel_1.name)
expect(browse_page).to have_no_channel(name: category_channel_2.name)
end
end
context "when results are not found" do
it "displays the correct message" do
chat_page.visit_browse
browse_page.search("x")
expect(browse_page).to have_channel(name: I18n.t("js.chat.empty_state.title"))
end
it "doesnt display any channel" do
chat_page.visit_browse
browse_page.search("x")
expect(browse_page).to have_no_channel(name: category_channel_1.name)
expect(browse_page).to have_no_channel(name: category_channel_2.name)
end
end
end
context "when visiting tabs" do
fab!(:category_channel_1) { Fabricate(:chat_channel, status: :open) }
fab!(:category_channel_2) { Fabricate(:chat_channel, status: :read_only) }
fab!(:category_channel_3) { Fabricate(:chat_channel, status: :closed) }
fab!(:category_channel_4) { Fabricate(:chat_channel, status: :archived) }
fab!(:category_channel_5) { Fabricate(:chat_channel, status: :open) }
fab!(:direct_message_channel_1) { Fabricate(:direct_message_channel, users: [current_user]) }
before { category_channel_5.destroy! }
shared_examples "never visible channels" do
it "doesnt list direct message channel" do
expect(browse_page).to have_no_channel(name: direct_message_channel_1.title(current_user))
end
it "doesnt list destroyed channels" do
expect(browse_page).to have_no_channel(name: category_channel_5.title)
end
end
context "when filter is all" do
it "lists all category channels" do
chat_page.visit_browse(:all)
expect(browse_page).to have_channel(name: category_channel_1.name)
expect(browse_page).to have_channel(name: category_channel_2.name)
expect(browse_page).to have_channel(name: category_channel_3.name)
expect(browse_page).to have_channel(name: category_channel_4.name)
end
context "when loading more" do
before { 25.times { Fabricate(:chat_channel, status: :open) } }
it "works" do
chat_page.visit_browse(:all)
scroll_to(find(".chat-channel-card:last-child"))
expect(browse_page).to have_selector(".chat-channel-card", count: 29)
end
end
include_examples "never visible channels" do
before { chat_page.visit_browse(:all) }
end
end
context "when filter is open" do
it "lists all opened category channels" do
chat_page.visit_browse(:open)
expect(browse_page).to have_channel(name: category_channel_1.name)
expect(browse_page).to have_no_channel(name: category_channel_2.name)
expect(browse_page).to have_no_channel(name: category_channel_3.name)
expect(browse_page).to have_no_channel(name: category_channel_4.name)
end
context "when loading more" do
fab!(:valid_channel) { Fabricate(:chat_channel, status: :open) }
fab!(:invalid_channel) { Fabricate(:chat_channel, status: :closed) }
it "keeps the filter" do
chat_page.visit_browse(:open)
expect(browse_page).to have_channel(name: valid_channel.title)
expect(browse_page).to have_no_channel(name: invalid_channel.title)
end
end
include_examples "never visible channels" do
before { chat_page.visit_browse(:open) }
end
end
context "when filter is closed" do
it "lists all closed category channels" do
chat_page.visit_browse(:closed)
expect(browse_page).to have_no_channel(name: category_channel_1.name)
expect(browse_page).to have_no_channel(name: category_channel_2.name)
expect(browse_page).to have_channel(name: category_channel_3.name)
expect(browse_page).to have_no_channel(name: category_channel_4.name)
end
context "when loading more" do
fab!(:valid_channel) { Fabricate(:chat_channel, status: :closed) }
fab!(:invalid_channel) { Fabricate(:chat_channel, status: :open) }
it "keeps the filter" do
chat_page.visit_browse(:closed)
expect(browse_page).to have_channel(name: valid_channel.title)
expect(browse_page).to have_no_channel(name: invalid_channel.title)
end
end
include_examples "never visible channels" do
before { chat_page.visit_browse(:closed) }
end
end
context "when filter is archived" do
before { SiteSetting.chat_allow_archiving_channels = true }
it "lists all archived category channels" do
chat_page.visit_browse(:archived)
expect(browse_page).to have_no_channel(name: category_channel_1.name)
expect(browse_page).to have_no_channel(name: category_channel_2.name)
expect(browse_page).to have_no_channel(name: category_channel_3.name)
expect(browse_page).to have_channel(name: category_channel_4.name)
end
context "when loading more" do
fab!(:valid_channel) { Fabricate(:chat_channel, status: :archived) }
fab!(:invalid_channel) { Fabricate(:chat_channel, status: :open) }
it "keeps the filter" do
chat_page.visit_browse(:archived)
expect(browse_page).to have_channel(name: valid_channel.title)
expect(browse_page).to have_no_channel(name: invalid_channel.title)
end
end
include_examples "never visible channels" do
before { chat_page.visit_browse(:archived) }
end
end
end
end
end