Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
Code Packages Activity Actions 9

PERF: avoid expensive OR clause query info more efficiently

Browse source
This commit is contained in:
Sam 2018-01-15 16:38:58 +11:00
parent 38c018a84b
commit fcfce3e426
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/topic_query.rb
View file

@ -512,7 +512,17 @@ class TopicQuery
if options[:no_subcategories] if options[:no_subcategories]
result = result.where('categories.id = ?', category_id) result = result.where('categories.id = ?', category_id)
else else
result = result.where('categories.id = :category_id OR (categories.parent_category_id = :category_id AND categories.topic_id <> topics.id)', category_id: category_id) sql = <<~SQL
categories.id IN (
SELECT c2.id FROM categories c2 WHERE c2.parent_category_id = :category_id
UNION ALL
SELECT :category_id
) AND
topics.id NOT IN (
SELECT c3.topic_id FROM categories c3 WHERE c3.parent_category_id = :category_id
)
SQL
result = result.where(sql, category_id: category_id)
end end
result = result.references(:categories) result = result.references(:categories)