FIX: badge selector showing up for anon

app/assets/javascripts/discourse/controllers/badges/show.js.es6

@@ -25,9 +25,9 @@ export default Ember.Controller.extend(BadgeSelectController, {
     return username ? userCount : modelCount;
   },
 
-  @computed("model.has_title_badges")
+  @computed("model.allow_title", "model.has_badge", "model")
-  canSelectTitle(hasTitleBadges) {
+  canSelectTitle(hasTitleBadges, hasBadge) {
-    return this.siteSettings.enable_badges && hasTitleBadges;
+    return this.siteSettings.enable_badges && hasTitleBadges && hasBadge;
   },
 
   actions: {

app/assets/javascripts/discourse/templates/badges/show.hbs

@@ -9,17 +9,13 @@
     {{badge-card badge=model size="large" count=userBadges.grant_count}}
     <div class='badge-grant-info {{if hiddenSetTitle '' 'hidden'}}'>
       <div>
-        {{#if model.allow_title}}
+        {{#if canSelectTitle}}
           <div class='grant-info-item'>
             {{i18n 'badges.allow_title'}}
-            {{#if userBadges}}
+            {{d-button
-              {{#if model.allow_title}}
-                {{d-button
                     class='btn btn-small pad-left no-text'
                     action='toggleSetUserTitle'
                     icon='pencil'}}
-              {{/if}}
-            {{/if}}
           </div>
         {{/if}}
         {{#if model.multiple_grant}}
@@ -29,10 +25,13 @@
         {{/if}}
       </div>
     </div>
-    <div class='badge-set-title {{if hiddenSetTitle 'hidden' ''}}'>
+
-      {{badge-title selectableUserBadges=selectableUserBadges user=user}}
+    {{#if canSelectTitle}}
-      <button class='btn btn-default close-btn' {{action "toggleSetUserTitle"}}>{{i18n 'close'}}</button>
+      <div class='badge-set-title {{if hiddenSetTitle 'hidden' ''}}'>
-    </div>
+        {{badge-title selectableUserBadges=selectableUserBadges user=user}}
+        <button class='btn btn-default close-btn' {{action "toggleSetUserTitle"}}>{{i18n 'close'}}</button>
+      </div>
+    {{/if}}
   </div>
 
   {{#if userBadges}}

app/controllers/badges_controller.rb

@@ -47,6 +47,9 @@ class BadgesController < ApplicationController
       if user_badge && user_badge.notification
         user_badge.notification.update_attributes read: true
       end
+      if user_badge
+        @badge.has_badge = true
+      end
     end
 
     serialized = MultiJson.dump(serialize_data(@badge, BadgeSerializer, root: "badge", include_long_description: true))

app/models/badge.rb

@@ -65,6 +65,9 @@ class Badge < ActiveRecord::Base
   # other consts
   AutobiographerMinBioLength = 10
 
+  # used by serializer
+  attr_accessor :has_badge
+
   def self.trigger_hash
     Hash[*(
       Badge::Trigger.constants.map { |k|

app/serializers/badge_serializer.rb

@@ -1,10 +1,18 @@
 class BadgeSerializer < ApplicationSerializer
   attributes :id, :name, :description, :grant_count, :allow_title,
              :multiple_grant, :icon, :image, :listable, :enabled, :badge_grouping_id,
-             :system, :long_description, :slug
+             :system, :long_description, :slug, :has_badge
 
   has_one :badge_type
 
+  def include_has_badge?
+    object.has_badge
+  end
+
+  def has_badge
+    true
+  end
+
   def system
     object.system?
   end