Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
Code Packages Activity Actions 13

improves danger formatting (#6162)

Browse source
This commit is contained in:
Joffrey JAFFEUX 2018-07-24 13:10:54 -04:00 • committed by GitHub
parent 7058205f70
commit e8b9bd7d9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Dangerfile
View file

@ -7,7 +7,6 @@ end
to_lint = git.modified_files + git.added_files to_lint = git.modified_files + git.added_files
files_to_lint = Shellwords.join(to_lint) files_to_lint = Shellwords.join(to_lint)
rubocop_output = `bundle exec rubocop -f json --parallel #{files_to_lint}` rubocop_output = `bundle exec rubocop -f json --parallel #{files_to_lint}`
if !rubocop_output.empty? if !rubocop_output.empty?
offenses = JSON.parse(rubocop_output)['files'] offenses = JSON.parse(rubocop_output)['files']
@ -23,16 +22,16 @@ if !rubocop_output.empty?
if !offenses.empty? if !offenses.empty?
fail(%{ fail(%{
This PR has multiple rubocop offenses:\n This PR has multiple rubocop offenses. We recommend configuring prettier linting in your editor:\n
#{offenses.map { |o| format_offense(o) }.join('\n') } #{offenses.map { |o| format_offense(o) }.join('\n') }
}) })
end end
end end
prettier_offenses = `prettier --list-different #{files_to_lint}`.split('\n') prettier_offenses = `prettier --list-different "app/assets/stylesheets/**/*.scss" "app/assets/javascripts/**/*.es6" "test/javascripts/**/*.es6" "plugins/**/*.scss" "plugins/**/*.es6"`.split('\n')
if !prettier_offenses.empty? if !prettier_offenses.empty?
fail(%{ fail(%{
This PR has multiple prettier offenses (we recommend configuring prettier linting in your editor):\n This PR has multiple prettier offenses (prettier.io). We recommend configuring prettier linting in your editor:\n
#{prettier_offenses.join("\n")} #{prettier_offenses.join("\n")}
}) })
end end