Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-10-03 17:21:20 +08:00
Code Packages Activity Actions 7

FIX: post voting comments editing UX (#35108)

Browse source 
was showing up inconditionnaly even if you didn't have the permissions
to edit other people's comments.

This was only a UX issue as the server is doing the correct check.

The issue was the `hasPermission` method which wasn't a getter so it
wasn't checked for all the instances of the post comments but rather
once.

Also added some acceptance tests to ensure we don't regress.

Internal ref - t/163347
This commit is contained in:
Régis Hanol 2025-10-01 11:31:19 +02:00 • committed by GitHub
parent 73664e3a69
commit e171530e14
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 43 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/discourse-post-voting/assets/javascripts/discourse/components/post-voting-comment-actions.gjs
View file

@ -16,7 +16,7 @@ export default class PostVotingCommentActions extends Component {

comment = this.args.comment;

hasPermission() {
get hasPermission() {
return (
this.comment.user_id === this.currentUser.id ||
this.currentUser.admin ||
@ -83,7 +83,6 @@ export default class PostVotingCommentActions extends Component {
@action={{this.deleteConfirm}}
@icon="far-trash-can"
/>

{{#if this.canFlag}}
<DButton
@display="link"

42
plugins/discourse-post-voting/test/javascripts/acceptance/post-voting-test.js
View file

@ -231,6 +231,10 @@ function setupPostVoting(needs, postStreamMode) {
"displays the right number of comments for the second post"
);

assert
.dom("#post_2 .post-voting-comment-action")
.doesNotExist("does not display comment action to anon users");

await click(".post-voting-comments-menu-show-more-link");

assert
@ -494,6 +498,44 @@ function setupPostVoting(needs, postStreamMode) {
.exists({ count: 3 }, "should add the new comment");
});

test("regular user can't edit other people's comments", async function (assert) {
updateCurrentUser({ id: 9876, admin: false, moderator: false }); // hasn't commented

await visit("/t/280");

assert
.dom("#post_2 .post-voting-comment-actions")
.doesNotExist(
"does not display edit link on other people's comments"
);
});

test("moderator can edit other people's comments", async function (assert) {
updateCurrentUser({ id: 9876, admin: false, moderator: true }); // hasn't commented

await visit("/t/280");

assert
.dom("#post_2 .post-voting-comment-actions")
.exists(
{ count: 5 },
"displays edit link on other people's comments"
);
});

test("admin can edit other people's comments", async function (assert) {
updateCurrentUser({ id: 9876, admin: true, moderator: false }); // hasn't commented

await visit("/t/280");

assert
.dom("#post_2 .post-voting-comment-actions")
.exists(
{ count: 5 },
"displays edit link on other people's comments"
);
});

test("editing a comment", async function (assert) {
updateCurrentUser({ id: 12345 }); // userId of comments in fixtures