Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 09:10:25 +08:00
Code Packages Activity Actions 11

Translate asterisks in ip addresses to mask format so people can enter things like 127.*.*.* in screened ip addresses form

Browse source
This commit is contained in:
Neil Lalonde 2014-02-18 13:00:46 -05:00
parent 69e0342d8f
commit d0ecccb7e4
2 changed files with 55 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

41
spec/models/screened_ip_address_spec.rb
View file

@ -47,6 +47,45 @@ describe ScreenedIpAddress do
end
end
describe "ip_address=" do
let(:record) { described_class.new }
def test_good_value(arg, expected)
record.ip_address = arg
record.ip_address_with_mask.should == expected
end
def test_bad_value(arg)
r = described_class.new
r.ip_address = arg
r.should_not be_valid
r.errors[:ip_address].should be_present
end
it "handles valid ip addresses" do
test_good_value("210.56.12.12", "210.56.12.12")
test_good_value("210.56.0.0/16", "210.56.0.0/16")
test_good_value("fc00::/7", "fc00::/7")
end
it "translates * characters" do
test_good_value("123.*.*.*", "123.0.0.0/8")
test_good_value("123.12.*.*", "123.12.0.0/16")
test_good_value("123.12.1.*", "123.12.1.0/24")
test_good_value("123.12.*.*/16", "123.12.0.0/16")
end
it "handles bad input" do
test_bad_value(nil)
test_bad_value("123.123")
test_bad_value("my house")
test_bad_value("123.*.1.12")
test_bad_value("*.123.*.12")
test_bad_value("*.*.*.12")
test_bad_value("123.*.1.12/8")
end
end
describe '#watch' do
context 'ip_address is not being watched' do
it 'should create a new record' do
@ -122,8 +161,6 @@ describe ScreenedIpAddress do
it "doesn't block fc00::/7 addresses (IPv6)" do
described_class.watch('fd12:db8::ff00:42:8329').action_type.should == described_class.actions[:do_nothing]
end
end
describe '#should_block?' do