Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-08 12:06:51 +08:00
Code Packages Activity Actions 1

FEATURE: Poll breakdown 2.0 (#10345)

Browse source 
The poll breakdown modal replaces the grouped pie charts feature.

Includes:

* MODAL: Untangle `onSelectPanel`
Previously modal-tab component would call on click the onSelectPanel callback with itself (modal-tab) as `this` which severely limited its usefulness. Now showModal binds the callback to its controller.

"The PR includes a fix/change to d-modal (b7f6ec6) that hasn't been extracted to a separate PR because it's not currently possible to test a change like this in abstract, i.e. with dynamically created controllers/components in tests. The percentage/count toggle test for the poll breakdown feature is essentially a test for that d-modal modification."
This commit is contained in:
Jarek Radosz 2020-08-06 17:57:06 +02:00 • committed by GitHub
parent 76c02cac65
commit cd4f251891
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
26 changed files with 708 additions and 294 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugins/poll/assets/javascripts/controllers/poll-ui-builder.js.es6
View file

@ -1,7 +1,7 @@
import I18n from "I18n";
import Controller from "@ember/controller";
import discourseComputed, { observes } from "discourse-common/utils/decorators";
import EmberObject from "@ember/object";
import discourseComputed, { observes } from "discourse-common/utils/decorators";
export const BAR_CHART_TYPE = "bar";
export const PIE_CHART_TYPE = "pie";