Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
Code Packages Activity Actions 9

Reduce number of Redis calls.

Browse source
This commit is contained in:
Guo Xiang Tan 2017-09-08 09:54:13 +08:00
parent 661ae38a03
commit b7ac33464f
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
app/services/random_topic_selector.rb
View file

@ -4,7 +4,7 @@ class RandomTopicSelector
BACKFILL_LOW_WATER_MARK = 500 BACKFILL_LOW_WATER_MARK = 500
def self.backfill(category = nil) def self.backfill(category = nil)
exclude = category.try(:topic_id) exclude = category&.topic_id
# don't leak private categories into the "everything" group # don't leak private categories into the "everything" group
user = category ? CategoryFeaturedTopic.fake_admin : nil user = category ? CategoryFeaturedTopic.fake_admin : nil
@ -28,10 +28,13 @@ class RandomTopicSelector
.pluck(:id) .pluck(:id)
key = cache_key(category) key = cache_key(category)
results.each do |id|
$redis.rpush(key, id) if results.present?
end $redis.multi do
$redis.rpush(key, results)
$redis.expire(key, 2.days) $redis.expire(key, 2.days)
end
end
results results
end end
@ -77,7 +80,7 @@ class RandomTopicSelector
end end
def self.cache_key(category = nil) def self.cache_key(category = nil)
"random_topic_cache_#{category.try(:id)}" "random_topic_cache_#{category&.id}"
end end
end end