Update rspec syntax to v3

update rspec syntax to v3

change syntax to rspec v3

oops. fix typo

mailers classes with rspec3 syntax

helpers with rspec3 syntax

jobs with rspec3 syntax

serializers with rspec3 syntax

views with rspec3 syntax

support to rspec3 syntax

category spec with rspec3 syntax

spec/models/trust_level3_requirements_spec.rb

@@ -16,51 +16,51 @@ describe TrustLevel3Requirements do
   describe "requirements" do
     it "min_days_visited uses site setting" do
       SiteSetting.stubs(:tl3_requires_days_visited).returns(66)
-      tl3_requirements.min_days_visited.should == 66
+      expect(tl3_requirements.min_days_visited).to eq(66)
     end
 
     it "min_topics_replied_to uses site setting" do
       SiteSetting.stubs(:tl3_requires_topics_replied_to).returns(12)
-      tl3_requirements.min_topics_replied_to.should == 12
+      expect(tl3_requirements.min_topics_replied_to).to eq(12)
     end
 
     it "min_topics_viewed depends on site setting and number of topics created" do
       SiteSetting.stubs(:tl3_requires_topics_viewed).returns(75)
       described_class.stubs(:num_topics_in_time_period).returns(31)
-      tl3_requirements.min_topics_viewed.should == 23
+      expect(tl3_requirements.min_topics_viewed).to eq(23)
     end
 
     it "min_posts_read depends on site setting and number of posts created" do
       SiteSetting.stubs(:tl3_requires_posts_read).returns(66)
       described_class.stubs(:num_posts_in_time_period).returns(1234)
-      tl3_requirements.min_posts_read.should == 814
+      expect(tl3_requirements.min_posts_read).to eq(814)
     end
 
     it "min_topics_viewed_all_time depends on site setting" do
       SiteSetting.stubs(:tl3_requires_topics_viewed_all_time).returns(75)
-      tl3_requirements.min_topics_viewed_all_time.should == 75
+      expect(tl3_requirements.min_topics_viewed_all_time).to eq(75)
     end
 
     it "min_posts_read_all_time depends on site setting" do
       SiteSetting.stubs(:tl3_requires_posts_read_all_time).returns(1001)
-      tl3_requirements.min_posts_read_all_time.should == 1001
+      expect(tl3_requirements.min_posts_read_all_time).to eq(1001)
     end
 
     it "max_flagged_posts depends on site setting" do
       SiteSetting.stubs(:tl3_requires_max_flagged).returns(3)
-      tl3_requirements.max_flagged_posts.should == 3
+      expect(tl3_requirements.max_flagged_posts).to eq(3)
     end
 
     it "min_likes_given depends on site setting" do
       SiteSetting.stubs(:tl3_requires_likes_given).returns(30)
-      tl3_requirements.min_likes_given.should == 30
+      expect(tl3_requirements.min_likes_given).to eq(30)
     end
 
     it "min_likes_received depends on site setting" do
       SiteSetting.stubs(:tl3_requires_likes_received).returns(20)
-      tl3_requirements.min_likes_received.should == 20
-      tl3_requirements.min_likes_received_days.should == 7
-      tl3_requirements.min_likes_received_users.should == 5
+      expect(tl3_requirements.min_likes_received).to eq(20)
+      expect(tl3_requirements.min_likes_received_days).to eq(7)
+      expect(tl3_requirements.min_likes_received_users).to eq(5)
     end
   end
 
@@ -71,7 +71,7 @@ describe TrustLevel3Requirements do
       user.update_posts_read!(1, 3.days.ago)
       user.update_posts_read!(0, 4.days.ago)
       user.update_posts_read!(3, 101.days.ago)
-      tl3_requirements.days_visited.should == 2
+      expect(tl3_requirements.days_visited).to eq(2)
     end
   end
 
@@ -88,7 +88,7 @@ describe TrustLevel3Requirements do
       topic2      = create_post(created_at: 101.days.ago).topic
       _reply2      = create_post(topic: topic2, user: user, created_at: 101.days.ago) # topic is over 100 days old
 
-      tl3_requirements.num_topics_replied_to.should == 1
+      expect(tl3_requirements.num_topics_replied_to).to eq(1)
     end
   end
 
@@ -99,7 +99,7 @@ describe TrustLevel3Requirements do
       make_view(9, 3.days.ago,   user.id) # same topic, different day
       make_view(3, 4.days.ago,   user.id)
       make_view(2, 101.days.ago, user.id) # too long ago
-      tl3_requirements.topics_viewed.should == 2
+      expect(tl3_requirements.topics_viewed).to eq(2)
     end
   end
 
@@ -110,7 +110,7 @@ describe TrustLevel3Requirements do
       user.update_posts_read!(1, 3.days.ago)
       user.update_posts_read!(0, 4.days.ago)
       user.update_posts_read!(5, 101.days.ago)
-      tl3_requirements.posts_read.should == 4
+      expect(tl3_requirements.posts_read).to eq(4)
     end
   end
 
@@ -120,7 +120,7 @@ describe TrustLevel3Requirements do
       make_view(10, 1.day.ago,    user.id)
       make_view(9,  100.days.ago, user.id)
       make_view(8,  101.days.ago, user.id)
-      tl3_requirements.topics_viewed_all_time.should == 3
+      expect(tl3_requirements.topics_viewed_all_time).to eq(3)
     end
   end
 
@@ -129,7 +129,7 @@ describe TrustLevel3Requirements do
       user.save
       user.update_posts_read!(3, 2.days.ago)
       user.update_posts_read!(1, 101.days.ago)
-      tl3_requirements.posts_read_all_time.should == 4
+      expect(tl3_requirements.posts_read_all_time).to eq(4)
     end
   end
 
@@ -159,8 +159,8 @@ describe TrustLevel3Requirements do
     end
 
     it "num_flagged_posts and num_flagged_by_users count spam and inappropriate agreed flags in the last 100 days" do
-      tl3_requirements.num_flagged_posts.should == 2
-      tl3_requirements.num_flagged_by_users.should == 3
+      expect(tl3_requirements.num_flagged_posts).to eq(2)
+      expect(tl3_requirements.num_flagged_by_users).to eq(3)
     end
   end
 
@@ -176,7 +176,7 @@ describe TrustLevel3Requirements do
       Fabricate(:like, user: user, post: recent_post2, created_at: 5.days.ago)
       Fabricate(:like, user: user, post: old_post,     created_at: 101.days.ago)
 
-      tl3_requirements.num_likes_given.should == 2
+      expect(tl3_requirements.num_likes_given).to eq(2)
     end
   end
 
@@ -196,9 +196,9 @@ describe TrustLevel3Requirements do
       Fabricate(:like, user: liker,  post: recent_post2, created_at: 5.days.ago)
       Fabricate(:like, user: liker,  post: old_post,     created_at: 101.days.ago)
 
-      tl3_requirements.num_likes_received.should == 3
-      tl3_requirements.num_likes_received_days.should == 2
-      tl3_requirements.num_likes_received_users.should == 2
+      expect(tl3_requirements.num_likes_received).to eq(3)
+      expect(tl3_requirements.num_likes_received_days).to eq(2)
+      expect(tl3_requirements.num_likes_received_users).to eq(2)
     end
   end
 
@@ -233,12 +233,12 @@ describe TrustLevel3Requirements do
     end
 
     it "are met when all requirements are met" do
-      tl3_requirements.requirements_met?.should == true
+      expect(tl3_requirements.requirements_met?).to eq(true)
     end
 
     it "are not met if too few days visited" do
       tl3_requirements.stubs(:days_visited).returns(49)
-      tl3_requirements.requirements_met?.should == false
+      expect(tl3_requirements.requirements_met?).to eq(false)
     end
 
     it "are not lost if requirements are close" do
@@ -248,77 +248,77 @@ describe TrustLevel3Requirements do
       tl3_requirements.stubs(:posts_read).returns(23)
       tl3_requirements.stubs(:num_likes_given).returns(29)
       tl3_requirements.stubs(:num_likes_received).returns(19)
-      tl3_requirements.requirements_lost?.should == false
+      expect(tl3_requirements.requirements_lost?).to eq(false)
     end
 
     it "are lost if not enough visited" do
       tl3_requirements.stubs(:days_visited).returns(44)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are lost if not enough topics replied to" do
       tl3_requirements.stubs(:num_topics_replied_to).returns(8)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are lost if not enough topics viewed" do
       tl3_requirements.stubs(:topics_viewed).returns(22)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are lost if not enough posts read" do
       tl3_requirements.stubs(:posts_read).returns(22)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are not met if not enough likes given" do
       tl3_requirements.stubs(:num_likes_given).returns(29)
-      tl3_requirements.requirements_met?.should == false
+      expect(tl3_requirements.requirements_met?).to eq(false)
     end
 
     it "are not met if not enough likes received" do
       tl3_requirements.stubs(:num_likes_received).returns(19)
-      tl3_requirements.requirements_met?.should == false
+      expect(tl3_requirements.requirements_met?).to eq(false)
     end
 
     it "are not met if not enough likes received on different days" do
       tl3_requirements.stubs(:num_likes_received_days).returns(6)
-      tl3_requirements.requirements_met?.should == false
+      expect(tl3_requirements.requirements_met?).to eq(false)
     end
 
     it "are not met if not enough likes received by different users" do
       tl3_requirements.stubs(:num_likes_received_users).returns(4)
-      tl3_requirements.requirements_met?.should == false
+      expect(tl3_requirements.requirements_met?).to eq(false)
     end
 
     it "are lost if not enough likes given" do
       tl3_requirements.stubs(:num_likes_given).returns(26)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are lost if not enough likes received" do
       tl3_requirements.stubs(:num_likes_received).returns(17)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are not met if suspended" do
       user.stubs(:suspended?).returns(true)
-      tl3_requirements.requirements_met?.should == false
+      expect(tl3_requirements.requirements_met?).to eq(false)
     end
 
     it "are lost if not enough likes received on different days" do
       tl3_requirements.stubs(:num_likes_received_days).returns(4)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are lost if not enough likes received by different users" do
       tl3_requirements.stubs(:num_likes_received_users).returns(3)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
 
     it "are lost if suspended" do
       user.stubs(:suspended?).returns(true)
-      tl3_requirements.requirements_lost?.should == true
+      expect(tl3_requirements.requirements_lost?).to eq(true)
     end
   end