Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 09:10:25 +08:00
Code Packages Activity Actions 11

FIX: [constructor] bbcode would cause markdown crash

Browse source
This commit is contained in:
Sam 2017-12-27 16:11:30 +11:00
parent 3937ff0425
commit a9e2fc59c4
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/assets/javascripts/pretty-text/engines/discourse-markdown-it.js.es6
View file

@ -50,7 +50,9 @@ class Ruler {
getRuleForTag(tag) {
this.ensureCache();
return this.cache[tag];
if (this.cache.hasOwnProperty(tag)) {
return this.cache[tag];
}
}
ensureCache() {

4
spec/components/pretty_text_spec.rb
View file

@ -155,6 +155,10 @@ describe PrettyText do
expect(cooked).to eq(html.strip)
end
it "handles bbcode edge cases" do
expect(PrettyText.cook "[constructor]\ntest").to eq("<p>[constructor]<br>\ntest</p>")
end
it "can handle quote edge cases" do
expect(PrettyText.cook("[quote]abc\ntest\n[/quote]")).not_to include('aside')
expect(PrettyText.cook("[quote] \ntest\n[/quote] ")).to include('aside')