Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-08 12:06:51 +08:00
Code Packages Activity Actions 1

FIX: DROP NOT NULL instead of changing all the rows in the table.

Browse source 
```
change_column :topic_views, :ip_address, :inet, null: true
```

translates to

```
"ALTER TABLE \"topic_views\" ALTER COLUMN \"ip_address\" TYPE inet"
```

which locks the whole table while the migration is taking place.
This commit is contained in:
Guo Xiang Tan 2018-07-17 10:59:48 +08:00
parent 818bc10107
commit a6e9f4f44b
2 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
db/migrate/20180521175611_change_indexes_topic_view_item.rb
View file

@ -1,12 +1,5 @@
class ChangeIndexesTopicViewItem < ActiveRecord::Migration[5.1] class ChangeIndexesTopicViewItem < ActiveRecord::Migration[5.1]
def up def up
begin
Migration::SafeMigrate.disable!
change_column :topic_views, :ip_address, :inet, null: true
ensure
Migration::SafeMigrate.enable!
end
remove_index :topic_views, remove_index :topic_views,
column: [:ip_address, :topic_id], column: [:ip_address, :topic_id],
name: :ip_address_topic_id_topic_views, name: :ip_address_topic_id_topic_views,

10
db/migrate/20180717025038_drop_not_null_ip_address_on_topic_views.rb Normal file
View file

@ -0,0 +1,10 @@
class DropNotNullIpAddressOnTopicViews < ActiveRecord::Migration[5.2]
def change
begin
Migration::SafeMigrate.disable!
change_column_null :topic_views, :ip_address, true
ensure
Migration::SafeMigrate.enable!
end
end
end