From a1b8a3b52b5bb5b7dff1117b46115c5fd376614b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Hanol?= Date: Wed, 17 May 2017 15:05:11 +0200 Subject: [PATCH] FIX: supports bare
  • when converting html to markdown --- lib/html_to_markdown.rb | 3 +-- spec/components/html_to_markdown_spec.rb | 4 ++++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/html_to_markdown.rb b/lib/html_to_markdown.rb index 2044d5e37f4..e5360477406 100644 --- a/lib/html_to_markdown.rb +++ b/lib/html_to_markdown.rb @@ -114,7 +114,7 @@ class HtmlToMarkdown def visit_li(node) parent = @stack.reverse.find { |n| n.name[/ul|ol|menu/] } - prefix = parent.name == "ol" ? "1. " : "- " + prefix = parent&.name == "ol" ? "1. " : "- " @stack << Block.new("li", prefix, " ") traverse(node) @markdown << format_block @@ -209,7 +209,6 @@ class HtmlToMarkdown end def format_block - lines = @stack[-1].markdown.each_line.map do |line| prefix = @stack.map { |b| b.opened ? b.body : b.head }.join @stack.each { |b| b.opened = true } diff --git a/spec/components/html_to_markdown_spec.rb b/spec/components/html_to_markdown_spec.rb index 3d77cc85e40..c6daa6286ba 100644 --- a/spec/components/html_to_markdown_spec.rb +++ b/spec/components/html_to_markdown_spec.rb @@ -181,6 +181,10 @@ describe HtmlToMarkdown do )).to eq("- Fruits\n - 🍏\n - 🍐\n - 🍌\n- Vegetables\n - 🍆\n - 🍅\n - 🍄") end + it "supports bare
  • " do + expect(html_to_markdown("
  • I'm alone
  • ")).to eq("- I'm alone") + end + it "supports
    " do
         expect(html_to_markdown("
    var foo = 'bar';
    ")).to eq("```\nvar foo = 'bar';\n```") expect(html_to_markdown("
    var foo = 'bar';
    ")).to eq("```\nvar foo = 'bar';\n```")