From 843a73e1ef29addc40a8c12b407714bb175c03dd Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Fri, 29 Mar 2019 08:50:18 +0100 Subject: [PATCH] DEV: more precise self pattern check (#7278) --- Dangerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dangerfile b/Dangerfile index f1603fb2ab4..b8f84230358 100644 --- a/Dangerfile +++ b/Dangerfile @@ -34,7 +34,7 @@ js_files.each do |path| diff.patch.lines.grep(/^\+\s\s/).each do |added_line| super_offenses << path if added_line['this._super()'] - self_offenses << path if added_line['self'] + self_offenses << path if added_line[/(?:(^|\W)self\.?)/] end end @@ -51,7 +51,7 @@ end if !self_offenses.empty? warn(%{ -Use fat arrow instead of self pattern.`\n +Use fat arrow instead of self pattern.\n #{self_offenses.uniq.map { |o| github.html_link(o) }.join("\n")} }) end