Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-07 12:02:53 +08:00
Code Packages Activity Actions 5

FIX: Better 0 file size detection and logging (#16116)

Browse source 
When creating files with create-multipart, if the file
size was somehow zero we were showing a very unhelpful
error message to the user. Now we show a nicer message,
and proactively don't call the API if we know the file
size is 0 bytes in JS, along with extra console logging
to help with debugging.
This commit is contained in:
Martin Brennan 2022-03-07 12:39:33 +10:00 • committed by GitHub
parent 5f5acfa064
commit 7af01d88d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 37 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/uploads_controller.rb
View file

@ -200,6 +200,10 @@ class UploadsController < ApplicationController
end
def validate_file_size(file_name:, file_size:)
if file_size.zero?
raise ExternalUploadValidationError.new(I18n.t("upload.size_zero_failure"))
end
if file_size_too_big?(file_name, file_size)
raise ExternalUploadValidationError.new(
I18n.t(