mirror of
https://github.com/discourse/discourse.git
synced 2025-09-08 12:06:51 +08:00
PERF: reuse renderer when rendering email templates
Previous to this fix we were leaking methods on the internal action view template class per render. This caused email generation to be very low and a steady memory leak in the application in sidekiq when sending out emails The behavior change is new to Rails 6 so this fix does not need to be backported into stable.
This commit is contained in:
parent
d45866eb5c
commit
71ea4ad7fc
4 changed files with 9 additions and 7 deletions
|
@ -94,9 +94,7 @@ module Email
|
|||
html_override.gsub!("%{respond_instructions}", "")
|
||||
end
|
||||
|
||||
html = UserNotificationRenderer.with_view_paths(
|
||||
Rails.configuration.paths["app/views"]
|
||||
).render(
|
||||
html = UserNotificationRenderer.instance.render(
|
||||
template: 'layouts/email_template',
|
||||
format: :html,
|
||||
locals: { html_body: html_override.html_safe }
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue