DEV: Fix rubocop issues (#14715)

script/bench.rb

@@ -297,7 +297,7 @@ begin
   run("RAILS_ENV=profile bundle exec rake assets:clean")
 
   def get_mem(pid)
-    YAML.load `ruby script/memstats.rb #{pid} --yaml`
+    YAML.safe_load `ruby script/memstats.rb #{pid} --yaml`
   end
 
   mem = get_mem(pid)

script/benchmarks/cache/bench.rb

@@ -46,7 +46,7 @@ Benchmark.ips do |x|
 
   x.report("redis get string marshal") do |times|
     while times > 0
-      Marshal.load(Discourse.redis.get("test_keym"))
+      Marshal.load(Discourse.redis.get("test_keym")) # rubocop:disable Security/MarshalLoad
       times -= 1
     end
   end

script/import_scripts/jforum.rb

@@ -10,7 +10,7 @@ class ImportScripts::JForum < ImportScripts::Base
   def initialize
     super
 
-    @settings = YAML.load(File.read(ARGV.first), symbolize_names: true)
+    @settings = YAML.safe_load(File.read(ARGV.first), symbolize_names: true)
 
     @database_client = Mysql2::Client.new(
       host: @settings[:database][:host],

script/import_scripts/mbox/support/indexer.rb

@@ -48,7 +48,7 @@ module ImportScripts::Mbox
       if File.exist?(metadata_file)
         # workaround for YML files that contain classname in file header
         yaml = File.read(metadata_file).sub(/^--- !.*$/, '---')
-        metadata = YAML.load(yaml)
+        metadata = YAML.safe_load(yaml)
       else
         metadata = {}
       end

script/import_scripts/nodebb/nodebb.rb

@@ -180,7 +180,7 @@ class ImportScripts::NodeBB < ImportScripts::Base
     if is_external
       # download external image
       begin
-        string_io = open(picture, read_timeout: 5)
+        string_io = uri.open(read_timeout: 5)
       rescue Net::ReadTimeout
         puts "timeout downloading avatar for user #{imported_user.id}"
         return nil
@@ -246,7 +246,7 @@ class ImportScripts::NodeBB < ImportScripts::Base
 
     if is_external
       begin
-        string_io = open(picture, read_timeout: 5)
+        string_io = uri.open(read_timeout: 5)
       rescue Net::ReadTimeout
         return nil
       end

script/import_scripts/smf2.rb

@@ -558,7 +558,7 @@ class ImportScripts::Smf2 < ImportScripts::Base
 
     def read_smf_settings
       settings = File.join(self.smfroot, 'Settings.php')
-      IO.readlines(settings).each do |line|
+      File.readlines(settings).each do |line|
         next unless m = /\$([a-z_]+)\s*=\s*['"](.+?)['"]\s*;\s*((#|\/\/).*)?$/.match(line)
         case m[1]
         when 'db_server' then self.host ||= m[2]

script/import_scripts/zendesk_api.rb

@@ -333,7 +333,7 @@ class ImportScripts::ZendeskApi < ImportScripts::Base
       attempts = 0
 
       begin
-        open("#{$1}") do |image|
+        URI.parse(image_url).open do |image|
           # IMAGE_DOWNLOAD_PATH is whatever image, it will be replaced with the downloaded image
           File.open(IMAGE_DOWNLOAD_PATH, "wb") do |file|
             file.write(image.read)

script/memstats.rb

@@ -131,7 +131,7 @@ def format_number(n)
 end
 
 def get_commandline(pid)
-  commandline = IO.read("/proc/#{pid}/cmdline").split("\0")
+  commandline = File.read("/proc/#{pid}/cmdline").split("\0")
   if commandline.first =~ /java$/ then
     loop { break if commandline.shift == "-jar" }
     return "[java] #{commandline.shift}"