From acbf82d8db750d97696c8c5bf98c8de6c3faf278 Mon Sep 17 00:00:00 2001 From: Kane York Date: Tue, 21 Jul 2015 15:48:39 -0700 Subject: [PATCH 01/13] FIX: Change post owner of deleted post, take 3 --- app/services/post_owner_changer.rb | 1 - spec/controllers/topics_controller_spec.rb | 1 - 2 files changed, 2 deletions(-) diff --git a/app/services/post_owner_changer.rb b/app/services/post_owner_changer.rb index bf8868591bd..c7aa0b7511f 100644 --- a/app/services/post_owner_changer.rb +++ b/app/services/post_owner_changer.rb @@ -16,7 +16,6 @@ class PostOwnerChanger @topic.user = @new_owner if post.is_first_post? if post.user == nil - post.recover! @topic.recover! if post.is_first_post? end post.topic = @topic diff --git a/spec/controllers/topics_controller_spec.rb b/spec/controllers/topics_controller_spec.rb index ae5c0523e46..049359715ba 100644 --- a/spec/controllers/topics_controller_spec.rb +++ b/spec/controllers/topics_controller_spec.rb @@ -258,7 +258,6 @@ describe TopicsController do t2.reload p3.reload expect(t2.deleted_at).to be_nil - expect(p3.deleted_at).to be_nil expect(p3.user).to eq(user_a) end end From 93d9a984970f2ca813bda09fb377a7abbb8b5cde Mon Sep 17 00:00:00 2001 From: Simon Cossar Date: Tue, 21 Jul 2015 18:46:15 -0700 Subject: [PATCH 02/13] Remove unnecessary margins from mobile view --- app/assets/stylesheets/mobile/discourse.scss | 10 +++++++++- app/assets/stylesheets/mobile/header.scss | 1 + app/assets/stylesheets/mobile/topic-list.scss | 6 +++--- app/assets/stylesheets/mobile/topic-post.scss | 9 +++++---- app/assets/stylesheets/mobile/topic.scss | 4 ++-- 5 files changed, 20 insertions(+), 10 deletions(-) diff --git a/app/assets/stylesheets/mobile/discourse.scss b/app/assets/stylesheets/mobile/discourse.scss index 30ebb6a6ee8..f4a32585b6b 100644 --- a/app/assets/stylesheets/mobile/discourse.scss +++ b/app/assets/stylesheets/mobile/discourse.scss @@ -6,12 +6,20 @@ body { background-color: $secondary; } +// This sets the space between the application content and the edge of the +// screen. This value is required in 'mobile/header.scss' to set the position +// of the drop-down menu. +$mobile-wrapper-padding: 10px; +.wrap { + padding: 0 $mobile-wrapper-padding; +} + body { .boxed { height: 100%; .contents { - padding: 10px; + padding: 10px 0; } &.white { background-color: $secondary; diff --git a/app/assets/stylesheets/mobile/header.scss b/app/assets/stylesheets/mobile/header.scss index ad2cfcb96b1..4b15cdccf1f 100644 --- a/app/assets/stylesheets/mobile/header.scss +++ b/app/assets/stylesheets/mobile/header.scss @@ -43,6 +43,7 @@ .d-dropdown { width: 290px; margin-top: -1px; + right: -$mobile-wrapper-padding; // Line-up with edge of screen, not edge of padding // Common diff --git a/app/assets/stylesheets/mobile/topic-list.scss b/app/assets/stylesheets/mobile/topic-list.scss index 4a4ab4423a9..5f71cddcad2 100644 --- a/app/assets/stylesheets/mobile/topic-list.scss +++ b/app/assets/stylesheets/mobile/topic-list.scss @@ -9,7 +9,7 @@ .category-breadcrumb.hidden { display: none; } - margin: 5px; + margin: 5px 0; .nav { float: left; margin-right: 15px; @@ -71,7 +71,7 @@ th, td { - padding: 7px 5px; + padding: 7px 0; color: scale-color($primary, $lightness: 50%); } @@ -223,7 +223,7 @@ tr.category-topic-link { .topic-list-bottom { - margin: 20px 12px 0 12px; + margin: 20px 0 0 0; } diff --git a/app/assets/stylesheets/mobile/topic-post.scss b/app/assets/stylesheets/mobile/topic-post.scss index e9c9ab8f879..7a16c078c19 100644 --- a/app/assets/stylesheets/mobile/topic-post.scss +++ b/app/assets/stylesheets/mobile/topic-post.scss @@ -167,7 +167,7 @@ a.star { .topic-map { - margin: 10px; + margin: 10px 0; background: dark-light-diff($primary, $secondary, 97%, -45%); border: 1px solid dark-light-diff($primary, $secondary, 90%, -65%); border-top: none; // would cause double top border @@ -300,8 +300,9 @@ a.star { } #topic-footer-buttons { + @include clearfix; border-top: 1px solid dark-light-diff($primary, $secondary, 90%, -60%); - padding: 20px 10px 0 10px; + padding: 20px 0 0 0; .fa-bookmark.bookmarked { color: $tertiary; } } @@ -313,7 +314,7 @@ a.star { #suggested-topics { clear: left; - padding: 20px 10px 15px 10px; + padding: 20px 0 15px 0; th.views, td.views, td.activity, th.activity, th.likes, td.likes { display: none; } @@ -344,7 +345,7 @@ span.post-count { #topic-title { z-index: 1000; margin: 0 0 0 0 !important; - padding: 15px 10px 15px 10px; + padding: 15px 0; } .topic-post { diff --git a/app/assets/stylesheets/mobile/topic.scss b/app/assets/stylesheets/mobile/topic.scss index 78cfe1b6f92..db76dd41f7d 100644 --- a/app/assets/stylesheets/mobile/topic.scss +++ b/app/assets/stylesheets/mobile/topic.scss @@ -14,8 +14,8 @@ .edits {margin-right: 5px;} #topic-title { - margin-bottom: 20px; - margin: 0 60px 10px 20px; + //margin-bottom: 20px; + margin: 0 60px 10px 0; h1 { font-size: 1.5em; line-height: 1.25em; From 5408abd4272f5703144e95816a54d59b50d98529 Mon Sep 17 00:00:00 2001 From: Kane York Date: Tue, 21 Jul 2015 17:35:03 -0700 Subject: [PATCH 03/13] Pull automatic share link copying --- .../javascripts/discourse/templates/share.hbs | 2 -- app/assets/javascripts/discourse/views/share.js.es6 | 13 +++---------- config/locales/client.en.yml | 1 - 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/app/assets/javascripts/discourse/templates/share.hbs b/app/assets/javascripts/discourse/templates/share.hbs index 5bd54e1d599..019da994781 100644 --- a/app/assets/javascripts/discourse/templates/share.hbs +++ b/app/assets/javascripts/discourse/templates/share.hbs @@ -1,6 +1,5 @@ {{#if controller.link}}

{{view.title}}

- {{i18n 'share.copied'}} {{#if date}} {{displayDate}} @@ -19,4 +18,3 @@ {{fa-icon "times-circle"}} {{/if}} - diff --git a/app/assets/javascripts/discourse/views/share.js.es6 b/app/assets/javascripts/discourse/views/share.js.es6 index 91c9c89ae00..4bc44acd9f9 100644 --- a/app/assets/javascripts/discourse/views/share.js.es6 +++ b/app/assets/javascripts/discourse/views/share.js.es6 @@ -1,4 +1,3 @@ -import copyText from 'discourse/lib/copy-text'; export default Discourse.View.extend({ templateName: 'share', @@ -36,6 +35,9 @@ export default Discourse.View.extend({ var $linkForTouch = $('#share-link .share-for-touch a'); $linkForTouch.attr('href',self.get('controller.link')); $linkForTouch.html(self.get('controller.link')); + var range = window.document.createRange(); + range.selectNode($linkForTouch[0]); + window.getSelection().addRange(range); } }); } @@ -63,7 +65,6 @@ export default Discourse.View.extend({ var $currentTarget = $(e.currentTarget), $currentTargetOffset = $currentTarget.offset(), $shareLink = $('#share-link'), - copyElement = document.getElementById('copy-target'), url = $currentTarget.data('share-url'), postNumber = $currentTarget.data('post-number'), date = $currentTarget.children().data('time'); @@ -94,18 +95,10 @@ export default Discourse.View.extend({ $shareLink.css({left: "" + x + "px"}); } - self.set('controller.copied', false); - - const copySuccess = copyText(url, copyElement); - self.set('controller.link', url); self.set('controller.postNumber', postNumber); self.set('controller.date', date); - Ember.run.later(null, function() { - self.set('controller.copied', copySuccess); - }, 50); - return false; }); diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml index d8f30a30749..82b1a903825 100644 --- a/config/locales/client.en.yml +++ b/config/locales/client.en.yml @@ -114,7 +114,6 @@ en: topic: 'share a link to this topic' post: 'post #%{postNumber}' close: 'close' - copied: 'copied to clipboard' twitter: 'share this link on Twitter' facebook: 'share this link on Facebook' google+: 'share this link on Google+' From 92ced4449fc2957fff3b3a86d2ad74c4e02cc6a2 Mon Sep 17 00:00:00 2001 From: Jeff Atwood Date: Tue, 21 Jul 2015 23:25:22 -0700 Subject: [PATCH 04/13] add back in sunglasses guy with nose --- app/assets/javascripts/discourse/lib/emoji/emoji.js.erb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/assets/javascripts/discourse/lib/emoji/emoji.js.erb b/app/assets/javascripts/discourse/lib/emoji/emoji.js.erb index 3358a665a7a..ef7856a7486 100644 --- a/app/assets/javascripts/discourse/lib/emoji/emoji.js.erb +++ b/app/assets/javascripts/discourse/lib/emoji/emoji.js.erb @@ -99,6 +99,7 @@ var translations = { ':|' : 'expressionless', ':-|' : 'expressionless', ':/' : 'confused', + '8-)' : 'sunglasses', ";P" : 'stuck_out_tongue_winking_eye', ";-P" : 'stuck_out_tongue_winking_eye', ":$" : 'blush', From 02c461c2e1fad071c0330b3da549242f18b7a6ee Mon Sep 17 00:00:00 2001 From: Jeff Atwood Date: Tue, 21 Jul 2015 23:29:31 -0700 Subject: [PATCH 05/13] fix awful copy for suppress email --- config/locales/client.en.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml index d8f30a30749..5fe85c630b2 100644 --- a/config/locales/client.en.yml +++ b/config/locales/client.en.yml @@ -539,7 +539,7 @@ en: email_direct: "Send me an email when someone quotes me, replies to my post, mentions my @username, or invites me to a topic" email_private_messages: "Send me an email when someone messages me" - email_always: "Do not suppress email notifications when I am active on the site" + email_always: "Send me email notifications even when I am active on the site" other_settings: "Other" categories_settings: "Categories" From 7e548257f4439e1da2dd41f51f90952574b4e5c4 Mon Sep 17 00:00:00 2001 From: Jeff Atwood Date: Tue, 21 Jul 2015 23:56:34 -0700 Subject: [PATCH 06/13] UX: add glyphs to notification states on profile --- .../javascripts/discourse/templates/user/preferences.hbs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/templates/user/preferences.hbs b/app/assets/javascripts/discourse/templates/user/preferences.hbs index 76f5446c9c0..775f93bd9db 100644 --- a/app/assets/javascripts/discourse/templates/user/preferences.hbs +++ b/app/assets/javascripts/discourse/templates/user/preferences.hbs @@ -216,17 +216,17 @@
- + {{category-group categories=model.watchedCategories blacklist=selectedCategories}}
{{i18n 'user.watched_categories_instructions'}}
- + {{category-group categories=model.trackedCategories blacklist=selectedCategories}}
{{i18n 'user.tracked_categories_instructions'}}
- + {{category-group categories=model.mutedCategories blacklist=selectedCategories}}
{{i18n 'user.muted_categories_instructions'}}
@@ -235,7 +235,7 @@
- + {{user-selector excludeCurrentUser=true usernames=model.muted_usernames class="user-selector"}}
{{i18n 'user.muted_users_instructions'}}
From ccdcca578d31b2f59fb2ecb0755ff69d0d4698f7 Mon Sep 17 00:00:00 2001 From: Jeff Atwood Date: Wed, 22 Jul 2015 01:12:03 -0700 Subject: [PATCH 07/13] remove fa-plus from upload dialog button --- .../discourse/templates/modal/upload_selector.hbs | 2 +- app/assets/stylesheets/common/base/upload.scss | 12 ------------ config/locales/client.en.yml | 6 +++--- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/app/assets/javascripts/discourse/templates/modal/upload_selector.hbs b/app/assets/javascripts/discourse/templates/modal/upload_selector.hbs index 394153f71b3..4423fe5f72d 100644 --- a/app/assets/javascripts/discourse/templates/modal/upload_selector.hbs +++ b/app/assets/javascripts/discourse/templates/modal/upload_selector.hbs @@ -38,7 +38,7 @@