Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
Code Packages Activity Actions 9

Add rubocop to our build. (#5004)

Browse source
This commit is contained in:
Guo Xiang Tan 2017-07-28 10:20:09 +09:00 • committed by GitHub
parent ff4e295c4f
commit 5012d46cbd
871 changed files with 5480 additions and 6056 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/controllers/admin/groups_controller_spec.rb
View file

@ -44,10 +44,10 @@ describe Admin::GroupsController do
group.add_owner(user)
expect do
xhr :put, :update, { id: group.id, group: {
xhr :put, :update, id: group.id, group: {
visibility_level: Group.visibility_levels[:owners],
allow_membership_requests: "true"
} }
}
end.to change { GroupHistory.count }.by(2)
@ -55,12 +55,12 @@ describe Admin::GroupsController do
group.reload
expect(group.visibility_level).to eq( Group.visibility_levels[:owners])
expect(group.visibility_level).to eq(Group.visibility_levels[:owners])
expect(group.allow_membership_requests).to eq(true)
end
it "ignore name change on automatic group" do
xhr :put, :update, { id: 1, group: { name: "WAT" } }
xhr :put, :update, id: 1, group: { name: "WAT" }
expect(response).to be_success
group = Group.find(1)
@ -70,14 +70,14 @@ describe Admin::GroupsController do
it "doesn't launch the 'automatic group membership' job when it's not retroactive" do
Jobs.expects(:enqueue).never
group = Fabricate(:group)
xhr :put, :update, { id: group.id, group: { automatic_membership_retroactive: "false" } }
xhr :put, :update, id: group.id, group: { automatic_membership_retroactive: "false" }
expect(response).to be_success
end
it "launches the 'automatic group membership' job when it's retroactive" do
group = Fabricate(:group)
Jobs.expects(:enqueue).with(:automatic_group_membership, group_id: group.id)
xhr :put, :update, { id: group.id, group: { automatic_membership_retroactive: "true" } }
xhr :put, :update, id: group.id, group: { automatic_membership_retroactive: "true" }
expect(response).to be_success
end