Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
Code Packages Activity Actions 9

BUGFIX: Fix issues if the DOM element is destroyed while the interval

Browse source 
is ongoing (in particular this was weird for Firefox)
This commit is contained in:
Robin Ward 2014-02-28 14:37:42 -05:00
parent 7d6984a915
commit 47357136dc
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
vendor/assets/javascripts/lock-on.js vendored
View file

@ -8,8 +8,12 @@
}; };
LockOn.prototype.elementTop = function() { LockOn.prototype.elementTop = function() {
var offsetCalculator = this.options.offsetCalculator; var offsetCalculator = this.options.offsetCalculator,
return $(this.selector).offset().top - (offsetCalculator ? offsetCalculator() : 0); selected = $(this.selector);
if (selected && selected.offset && selected.offset()) {
return selected.offset().top - (offsetCalculator ? offsetCalculator() : 0);
}
}; };
LockOn.prototype.lock = function() { LockOn.prototype.lock = function() {
@ -26,6 +30,12 @@
var top = self.elementTop(), var top = self.elementTop(),
scrollTop = $(window).scrollTop(); scrollTop = $(window).scrollTop();
if (typeof(top) === "undefined") {
$('body,html').off(scrollEvents)
clearInterval(interval);
return;
}
if ((top !== previousTop) || (scrollTop !== top)) { if ((top !== previousTop) || (scrollTop !== top)) {
$(window).scrollTop(top); $(window).scrollTop(top);
previousTop = top; previousTop = top;