Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-08 12:06:51 +08:00
Code Packages Activity Actions 1

DEV: Fix implementation for DiscourseRedis#exists.

Browse source
This commit is contained in:
Guo Xiang Tan 2020-06-01 13:11:06 +08:00
parent 00aab49829
commit 389bdcf5ab
No known key found for this signature in database
GPG key ID: FBD110179AAC1F20
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/discourse_redis.rb
View file

@ -208,13 +208,15 @@ class DiscourseRedis
end end
end end
# Remove when this has been upstreamed in https://github.com/redis/redis-rb/pull/911 # Implement our own because https://github.com/redis/redis-rb/issues/698 has stalled
def exists(*keys) def exists(*keys)
keys.map! { |a| "#{namespace}:#{a}" } if @namespace keys.map! { |a| "#{namespace}:#{a}" } if @namespace
DiscourseRedis.ignore_readonly do DiscourseRedis.ignore_readonly do
@redis._client.call([:exists, *keys]) do |value| @redis.synchronize do |client|
value > 0 client.call([:exists, *keys]) do |value|
value > 0
end
end end
end end
end end

1
spec/components/discourse_redis_spec.rb
View file

@ -88,7 +88,6 @@ describe DiscourseRedis do
end end
end end
# Remove when this has been upstreamed in https://github.com/redis/redis-rb/pull/911
describe '.exists' do describe '.exists' do
it 'should return false when key is not present' do it 'should return false when key is not present' do
expect(Discourse.redis.exists('test')).to eq(false) expect(Discourse.redis.exists('test')).to eq(false)