From 378bc6e5dc34da9b7e7a94355abe2a9a8ff1ec56 Mon Sep 17 00:00:00 2001 From: Akshay Date: Sat, 4 Oct 2014 09:53:46 +0530 Subject: [PATCH] private methods need to be called as method_name instead of ClassName#method_name --- app/models/top_topic.rb | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/models/top_topic.rb b/app/models/top_topic.rb index d9253ae74eb..cad2eebc97a 100644 --- a/app/models/top_topic.rb +++ b/app/models/top_topic.rb @@ -14,7 +14,7 @@ class TopTopic < ActiveRecord::Base # We don't have to refresh these as often def self.refresh_older! - older_periods = TopTopic.periods - [:daily] + older_periods = periods - [:daily] transaction do older_periods.each do |period| @@ -24,8 +24,8 @@ class TopTopic < ActiveRecord::Base end def self.refresh! - TopTopic.refresh_daily! - TopTopic.refresh_older! + refresh_daily! + refresh_older! end @@ -38,10 +38,10 @@ class TopTopic < ActiveRecord::Base end def self.update_counts_and_compute_scores_for(period) - TopTopic.sort_orders.each do |sort| + sort_orders.each do |sort| TopTopic.send("update_#{sort}_count_for", period) end - TopTopic.compute_top_score_for(period) + compute_top_score_for(period) end def self.remove_invisible_topics @@ -90,7 +90,7 @@ class TopTopic < ActiveRecord::Base AND user_id <> #{Discourse.system_user.id} GROUP BY topic_id" - TopTopic.update_top_topics(period, "posts", sql) + update_top_topics(period, "posts", sql) end def self.update_views_count_for(period) @@ -99,7 +99,7 @@ class TopTopic < ActiveRecord::Base WHERE viewed_at >= :from GROUP BY topic_id" - TopTopic.update_top_topics(period, "views", sql) + update_top_topics(period, "views", sql) end def self.update_likes_count_for(period) @@ -111,7 +111,7 @@ class TopTopic < ActiveRecord::Base AND post_type = #{Post.types[:regular]} GROUP BY topic_id" - TopTopic.update_top_topics(period, "likes", sql) + update_top_topics(period, "likes", sql) end def self.compute_top_score_for(period)