Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-05 08:59:27 +08:00
Code Packages Activity Actions 11

select-kit refactoring

Browse source 
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
This commit is contained in:
Joffrey JAFFEUX 2017-12-22 13:08:12 +01:00 • committed by GitHub
parent 364e6fdd53
commit 315b9d796d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
60 changed files with 827 additions and 641 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/poll/test/javascripts/acceptance/poll-builder-disabled-test.js.es6
View file

@ -1,12 +1,16 @@
import { acceptance } from "helpers/qunit-helpers";
import { displayPollBuilderButton } from "discourse/plugins/poll/helpers/display-poll-builder-button";
import { replaceCurrentUser } from "discourse/plugins/poll/helpers/replace-current-user";
import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
acceptance("Poll Builder - polls are disabled", {
loggedIn: true,
settings: {
poll_enabled: false,
poll_minimum_trust_level_to_create: 2
},
beforeEach: function() {
clearPopupMenuOptionsCallback();
}
});

4
plugins/poll/test/javascripts/acceptance/poll-builder-enabled-test.js.es6
View file

@ -1,12 +1,16 @@
import { acceptance } from "helpers/qunit-helpers";
import { displayPollBuilderButton } from "discourse/plugins/poll/helpers/display-poll-builder-button";
import { replaceCurrentUser } from "discourse/plugins/poll/helpers/replace-current-user";
import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
acceptance("Poll Builder - polls are enabled", {
loggedIn: true,
settings: {
poll_enabled: true,
poll_minimum_trust_level_to_create: 1
},
beforeEach: function() {
clearPopupMenuOptionsCallback();
}
});

6
plugins/poll/test/javascripts/acceptance/polls-test.js.es6
View file

@ -1,8 +1,12 @@
import { acceptance } from "helpers/qunit-helpers";
import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
acceptance("Rendering polls", {
loggedIn: true,
settings: { poll_enabled: true }
settings: { poll_enabled: true },
beforeEach: function() {
clearPopupMenuOptionsCallback();
}
});
test("Single Poll", (assert) => {

3
plugins/poll/test/javascripts/helpers/display-poll-builder-button.js.es6
View file

@ -2,6 +2,5 @@ export function displayPollBuilderButton() {
visit("/");
click("#create-topic");
click(".d-editor-button-bar .options");
expandSelectKit('.toolbar-popup-menu-options');
selectKit(".toolbar-popup-menu-options").expand();
}