From 100a84d34595d086ac03fdc7619232e9c0d070d5 Mon Sep 17 00:00:00 2001 From: Rafael dos Santos Silva Date: Wed, 16 Mar 2022 17:08:10 -0300 Subject: [PATCH] DEV: Reserve assigned notification type (#16207) * DEV: Reserve assigned notification type * update constants --- .../discourse/tests/fixtures/concerns/notification-types.js | 2 ++ app/models/notification.rb | 3 ++- spec/models/notification_spec.rb | 1 + spec/requests/api/schemas/json/site_response.json | 3 +++ 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/tests/fixtures/concerns/notification-types.js b/app/assets/javascripts/discourse/tests/fixtures/concerns/notification-types.js index eb643642964..0817993cf50 100644 --- a/app/assets/javascripts/discourse/tests/fixtures/concerns/notification-types.js +++ b/app/assets/javascripts/discourse/tests/fixtures/concerns/notification-types.js @@ -35,4 +35,6 @@ export const NOTIFICATION_TYPES = { chat_message: 30, chat_invitation: 31, chat_group_mention: 32, + chat_quoted: 33, + assigned: 34, }; diff --git a/app/models/notification.rb b/app/models/notification.rb index 8cd35dd7698..48dcb229583 100644 --- a/app/models/notification.rb +++ b/app/models/notification.rb @@ -110,7 +110,8 @@ class Notification < ActiveRecord::Base chat_message: 30, chat_invitation: 31, chat_group_mention: 32, # March 2022 - This is obsolete, as all chat_mentions use `chat_mention` type - chat_quoted: 33 + chat_quoted: 33, + assigned: 34 ) end diff --git a/spec/models/notification_spec.rb b/spec/models/notification_spec.rb index 692e4685db3..2d897b22ae4 100644 --- a/spec/models/notification_spec.rb +++ b/spec/models/notification_spec.rb @@ -51,6 +51,7 @@ describe Notification do expect(@types[:event_invitation]).to eq(28) expect(@types[:chat_mention]).to eq(29) expect(@types[:chat_message]).to eq(30) + expect(@types[:assigned]).to eq(34) end end end diff --git a/spec/requests/api/schemas/json/site_response.json b/spec/requests/api/schemas/json/site_response.json index adee9695dde..f8922a39801 100644 --- a/spec/requests/api/schemas/json/site_response.json +++ b/spec/requests/api/schemas/json/site_response.json @@ -106,6 +106,9 @@ }, "chat_quoted": { "type": "integer" + }, + "assigned": { + "type": "integer" } }, "required": [