Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-04 08:47:37 +08:00
Code Packages Activity Actions 12

FIX: email_domains_whitelist prevented creation of anonymous users

Browse source
This commit is contained in:
Gerhard Schlager 2018-03-06 18:14:53 +01:00
parent 76e2b6c825
commit 07649cd42d
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/services/anonymous_shadow_creator.rb
View file

@ -36,6 +36,7 @@ class AnonymousShadowCreator
shadow = User.create!( shadow = User.create!(
password: SecureRandom.hex, password: SecureRandom.hex,
email: "#{SecureRandom.hex}@anon.#{Discourse.current_hostname}", email: "#{SecureRandom.hex}@anon.#{Discourse.current_hostname}",
skip_email_validation: true,
name: username, # prevents error when names are required name: username, # prevents error when names are required
username: username, username: username,
active: true, active: true,

7
spec/services/anonymous_shadow_creator_spec.rb
View file

@ -10,7 +10,7 @@ describe AnonymousShadowCreator do
before { SiteSetting.allow_anonymous_posting = true } before { SiteSetting.allow_anonymous_posting = true }
let(:user) { Fabricate(:user, trust_level: 3) } let(:user) { Fabricate(:user_single_email, trust_level: 3) }
it "returns no shadow if trust level is not met" do it "returns no shadow if trust level is not met" do
expect(AnonymousShadowCreator.get(Fabricate.build(:user, trust_level: 0))).to eq(nil) expect(AnonymousShadowCreator.get(Fabricate.build(:user, trust_level: 0))).to eq(nil)
@ -67,6 +67,11 @@ describe AnonymousShadowCreator do
expect { AnonymousShadowCreator.get(user) }.to_not raise_error expect { AnonymousShadowCreator.get(user) }.to_not raise_error
end end
it "works when there is an email whitelist" do
SiteSetting.email_domains_whitelist = "wayne.com"
expect { AnonymousShadowCreator.get(user) }.to_not raise_error
end
end end
end end