Discourse/discourse
Discourse/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
Code Packages Activity Actions 9

FIX: Properly encode string literals in hbs compiler

Browse source
This commit is contained in:
Robin Ward 2017-10-04 12:48:14 -04:00
parent ddbd1d5ab8
commit 051b49efdb
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/javascripts/widget-hbs-compiler.js.es6
View file

@ -11,7 +11,12 @@ function sexp(value) {
let result = [];
value.hash.pairs.forEach(p => {
result.push(`"${p.key}": ${p.value.original}`);
let pValue = p.value.original;
if (p.value.type === "StringLiteral") {
pValue = JSON.stringify(pValue);
}
result.push(`"${p.key}": ${pValue}`);
});
return `{ ${result.join(", ")} }`;

2
script/test_hbs_compiler.rb
View file

@ -3,7 +3,7 @@ template = <<~HBS
{{a}}
{{{htmlValue}}}
{{#if state.category}}
{{attach widget="category-display" attrs=(hash category=state.category)}}
{{attach widget="category-display" attrs=(hash category=state.category someNumber=123 someString="wat")}}
{{/if}}
HBS