From e6dcbe86b64954558321fe8f12abc19fac776cd9 Mon Sep 17 00:00:00 2001 From: 4suredev <64234115+4suredev@users.noreply.github.com> Date: Thu, 19 Jun 2025 08:36:26 +0800 Subject: [PATCH] Check response before comparing versions --- custom-visual-builder-button.php | 2 +- updater.php | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/custom-visual-builder-button.php b/custom-visual-builder-button.php index 161b2bc..3ab14c8 100644 --- a/custom-visual-builder-button.php +++ b/custom-visual-builder-button.php @@ -3,7 +3,7 @@ * Plugin Name: 4sure - Avada Button Shortcode * Plugin URI: https://4sure.com.au * Description: Adds Avada button shortcodes to the classic editor - * Version: 1.0.7 + * Version: 1.0.8 * Author: 4sure * Requires PHP: 7.2 * Requires at least: 5.8 diff --git a/updater.php b/updater.php index 3b10c47..29622b8 100644 --- a/updater.php +++ b/updater.php @@ -47,7 +47,7 @@ class Custom_visual_builder_button_updater { } public function initialize() { /* Adding a filter to the transient. */ - add_filter( 'pre_set_site_transient_update_plugins', array( $this, 'modify_transient' ), 10, 1 ); + add_filter( 'pre_set_site_transient_update_plugins', array( $this, 'modify_transient' ), 10, 1 ); add_filter( 'plugins_api', array( $this, 'plugin_popup' ), 10, 3); add_filter( 'upgrader_post_install', array( $this, 'after_install' ), 10, 3 ); // Add Authorization Token to download_package @@ -60,15 +60,14 @@ class Custom_visual_builder_button_updater { } public function modify_transient( $transient ) { if( property_exists( $transient, 'checked') ) { // Check if transient has a checked property - if( $transient->checked ) { // Did WordPress check for updates? - $checked = $transient->checked; + if( $checked = $transient->checked ) { // Did WordPress check for updates? $this->get_repository_info(); // Get the repo info - if (!empty($checked[$this->basename])) { - $out_of_date = version_compare( $this->github_response['tag_name'], $checked[$this->basename], 'gt' ); // Check if we're out of date + if( is_array($this->github_response) && !empty($this->github_response['tag_name']) && !empty($checked[$this->basename]) ) { // Check response + $out_of_date = version_compare( $this->github_response['tag_name'], $checked[$this->basename], 'gt' ); // Check if we're out of date } else { $out_of_date = false; } - if( $out_of_date != false ) { + if( $out_of_date ) { $new_files = $this->github_response['zipball_url']; // Get the ZIP $slug = current( explode('/', $this->basename ) ); // Create valid slug $plugin = array( // setup our plugin info