diff --git a/custom-visual-builder-button.php b/custom-visual-builder-button.php
index 3ab14c8..8fc56e3 100644
--- a/custom-visual-builder-button.php
+++ b/custom-visual-builder-button.php
@@ -1,9 +1,9 @@
'',
@@ -52,7 +52,7 @@ function vbb_custom_visual_builder_button($atts = array()){
return $html;
}
//add media button to visual builder
-function vbb_add_shortcodes_media_button() {
+function add_shortcodes_media_button() {
$the_page = get_current_screen();
$current_page = $the_page->post_type;
$allowed = array(
@@ -61,11 +61,10 @@ function vbb_add_shortcodes_media_button() {
'product',
'tribe_events'
);
- if (in_array($current_page, $allowed, false) || $the_page->base == 'toplevel_page_access-manager' || $the_page->base == 'post' || $the_page->base == 'toplevel_page_acc-default-settings'){
+ if (in_array($current_page, $allowed, false) || $the_page->base == 'toplevel_page_access-manager' || $the_page->base == 'post'){
printf( '' . ' %s' . '', '#', __( 'Generate Button', 'textdomain' ) );
}
- $current_screen = get_current_screen()->base;
- if ($current_screen == 'toplevel_page_access-manager' || $current_screen == 'toplevel_page_acc-default-settings'){
+ if(get_current_screen()->base == 'toplevel_page_access-manager'){
echo '';
}
}
-add_action( 'media_buttons', 'vbb_add_shortcodes_media_button');
+add_action( 'media_buttons', 'add_shortcodes_media_button');
//Button shortcode admin bar widget
-add_action('admin_enqueue_scripts', 'vbb_admin_scripts_enqueue');
-function vbb_admin_scripts_enqueue($hook) {
+add_action('admin_enqueue_scripts', 'my_enqueue');
+function my_enqueue($hook) {
// Only add to the edit post/page admin page.
- if ('post.php' == $hook || 'post-new.php' == $hook || 'toplevel_page_access-manager' == $hook || 'toplevel_page_acc-default-settings' == $hook) {
- wp_enqueue_script('admin_custom_script', VBB_PLUGIN_PATH.'js/custom-admin-scripts.js', array('jquery-ui-dialog'));
+ if ('post.php' == $hook || 'post-new.php' == $hook || 'toplevel_page_access-manager' == $hook) {
+ wp_enqueue_script('admin_custom_script', VBB_PLUGIN_PATH.'js/custom-admin-scripts.js');
wp_enqueue_script('jquery-ui', 'https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.13.2/jquery-ui.min.js');
}else{return;}
}
-add_action( 'edit_form_after_editor', 'vbb_render_button_shortcode_dialog' );
-add_action( 'toplevel_page_access-manager', 'vbb_render_button_shortcode_dialog', 20 );
-add_action( 'toplevel_page_acc-default-settings', 'vbb_render_button_shortcode_dialog', 20 );
-function vbb_render_button_shortcode_dialog( $post ){
+add_action( 'edit_form_after_editor', 'render_button_shortcode_dialog' );
+add_action( 'toplevel_page_access-manager', 'render_button_shortcode_dialog', 20 );
+function render_button_shortcode_dialog( $post ){
echo '
';
}
\ No newline at end of file
diff --git a/js/custom-admin-scripts.js b/js/custom-admin-scripts.js
index 8a7a05b..75c6c3c 100644
--- a/js/custom-admin-scripts.js
+++ b/js/custom-admin-scripts.js
@@ -14,22 +14,13 @@ jQuery(document).ready(function($){
},
minWidth: 480
});
- if(typeof acf != 'undefined'){
- acf.addAction('load', function(){
- $(document).on("click", ".generate-button-shortcode", function(e){
- e.preventDefault();
- $("#button-shortcode-dialog").dialog("open");
- $("#page-mask").css({"opacity":1, "pointer-events": "auto"});
- });
- });
- }else{
+ acf.addAction('load', function(){
$(document).on("click", ".generate-button-shortcode", function(e){
e.preventDefault();
$("#button-shortcode-dialog").dialog("open");
$("#page-mask").css({"opacity":1, "pointer-events": "auto"});
});
- }
-
+ });
$('.generate-button-shortcode').click(function(e){
e.preventDefault();
$("#button-shortcode-dialog").dialog("open");
diff --git a/updater.php b/updater.php
index 29622b8..2bc76fc 100644
--- a/updater.php
+++ b/updater.php
@@ -47,7 +47,7 @@ class Custom_visual_builder_button_updater {
}
public function initialize() {
/* Adding a filter to the transient. */
- add_filter( 'pre_set_site_transient_update_plugins', array( $this, 'modify_transient' ), 10, 1 );
+ add_filter( 'pre_set_site_transient_update_plugins', array( $this, 'modify_transient' ), 10, 1 );
add_filter( 'plugins_api', array( $this, 'plugin_popup' ), 10, 3);
add_filter( 'upgrader_post_install', array( $this, 'after_install' ), 10, 3 );
// Add Authorization Token to download_package
@@ -60,13 +60,9 @@ class Custom_visual_builder_button_updater {
}
public function modify_transient( $transient ) {
if( property_exists( $transient, 'checked') ) { // Check if transient has a checked property
- if( $checked = $transient->checked ) { // Did WordPress check for updates?
+ if( $checked = $transient->checked ) { // Did WordPress check for updates?
$this->get_repository_info(); // Get the repo info
- if( is_array($this->github_response) && !empty($this->github_response['tag_name']) && !empty($checked[$this->basename]) ) { // Check response
- $out_of_date = version_compare( $this->github_response['tag_name'], $checked[$this->basename], 'gt' ); // Check if we're out of date
- } else {
- $out_of_date = false;
- }
+ $out_of_date = version_compare( $this->github_response['tag_name'], $checked[$this->basename], 'gt' ); // Check if we're out of date
if( $out_of_date ) {
$new_files = $this->github_response['zipball_url']; // Get the ZIP
$slug = current( explode('/', $this->basename ) ); // Create valid slug